Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

handle case when file not selected - continue of #374 #521

Closed
wants to merge 1 commit into from
Closed

handle case when file not selected - continue of #374 #521

wants to merge 1 commit into from

Conversation

tunnckoCore
Copy link
Member

while form upload file, if not select file, still create an empty temporary file!

from #374

@geemo @tunnckoCore
update incoming_form.js
2b5b955 
while form upload file, if not select file, still create an empty temporary file!
@tunnckoCore
Copy link
Member Author

tunnckoCore commented Nov 28, 2019 •
edited
Loading

Okay, this seems to fail, tests never end - I canceled them. Not sure if we need to replace the undefined case or it should be that way.

@GrosSacASac GrosSacASac mentioned this pull request Dec 5, 2019
Closed
@tunnckoCore
Copy link
Member Author

tunnckoCore commented Jan 29, 2020 •
edited
Loading

Oh yea. I was wondering today which issue/pr was that and what was it about ;d

Linking #545 and #415 to have it more near to my stuff.

Also, it probably is fixed too, because it checks against !part.mime to detect whether it's a file or field.

We should add some option to control it through option

@tunnckoCore tunnckoCore deleted the empty-temp-file-fix branch January 29, 2020 17:48
@tunnckoCore tunnckoCore mentioned this pull request Jan 29, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunnckoCore @geemo