Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implemented Snapshot.export #58

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions test/cpu_cprofiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,34 @@ describe('HEAP', function() {
);
});

it('should export itself to stream', function(done) {
var snapshot = profiler.takeSnapshot();
var fs = require('fs'),
ws = fs.createWriteStream('snapshot.json');

snapshot.export(ws);
ws.on('finish', done);
});

it('should pipe itself to stream', function(done) {
var snapshot = profiler.takeSnapshot();
var fs = require('fs'),
ws = fs.createWriteStream('snapshot.json')
.on('finish', done);

snapshot.export().pipe(ws);
});

it('should export itself to callback', function(done) {
var snapshot = profiler.takeSnapshot();

snapshot.export(function(err, result) {
expect(!err);
expect(typeof result == 'string');
done();
});
});

});

function deleteAllSnapshots() {
Expand Down
36 changes: 36 additions & 0 deletions v8-profiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ var path = require('path');
var binding_path = binary.find(path.resolve(path.join(__dirname,'./package.json')));
var binding = require(binding_path);

var Stream = require('stream').Stream,
inherits = require('util').inherits;

function Snapshot() {}

Snapshot.prototype.getHeader = function() {
Expand Down Expand Up @@ -35,6 +38,39 @@ Snapshot.prototype.compare = function(other) {
return diff;
};

function ExportStream() {
Stream.Transform.call(this);
this._transform = function noTransform(chunk, encoding, done) {
done(null, chunk);
}
}
inherits(ExportStream, Stream.Transform);

/**
* @param {Stream.Writable|function} dataReceiver
* @returns {Stream|function}
*/
Snapshot.prototype.export = function(dataReceiver) {
dataReceiver = dataReceiver || new ExportStream();

var toStream = dataReceiver instanceof Stream,
chunks = toStream ? null : [];

function onChunk(chunk, len) {
if (toStream) dataReceiver.write(chunk);
else chunks.push(chunk);
}

function onDone() {
if (toStream) dataReceiver.end();
else dataReceiver(null, chunks.join(''));
}

this.serialize(onChunk, onDone);

return dataReceiver;
};

function nodes(snapshot) {
var n = snapshot.nodesCount, i, nodes = [];
for (i = 0; i < n; i++) {
Expand Down