Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use correct type for options #360

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Use correct type for options #360

merged 1 commit into from
Jul 23, 2023

Conversation

bc-m
Copy link
Contributor

@bc-m bc-m commented Jul 21, 2023

No description provided.

@cjbarth
Copy link
Contributor

cjbarth commented Jul 22, 2023

If you can clean up these errors I'll merge this and do a 4.0.1 release.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #360 (cfb26f7) into master (0711039) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files           9        9           
  Lines         856      856           
  Branches      227      227           
=======================================
  Hits          618      618           
  Misses        137      137           
  Partials      101      101           
Impacted Files Coverage Δ
src/signed-xml.ts 74.18% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bc-m
Copy link
Contributor Author

bc-m commented Jul 22, 2023

If you can clean up these errors I'll merge this and do a 4.0.1 release.

Done. 🙂

@cjbarth cjbarth merged commit 1b0629e into node-saml:master Jul 23, 2023
@cjbarth cjbarth added the bug label Jul 23, 2023
@cjbarth
Copy link
Contributor

cjbarth commented Jul 23, 2023

4.0.1 release

Done.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants