Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make references accessible only via get/set #395

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Oct 6, 2023

The references array is a little sensitive to what is in it, we don't want people mutating it without the accessors.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #395 (2657fa1) into master (c2b8cd6) will decrease coverage by 0.32%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   74.46%   74.14%   -0.32%     
==========================================
  Files           9        9              
  Lines         881      882       +1     
  Branches      234      233       -1     
==========================================
- Hits          656      654       -2     
- Misses        132      135       +3     
  Partials       93       93              
Files Coverage Δ
src/signed-xml.ts 76.69% <83.33%> (-0.68%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit 0d01641 into node-saml:master Oct 6, 2023
@cjbarth cjbarth deleted the private_references branch October 6, 2023 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant