Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Frontend] Company size field on request form #245

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Conversation

williammfu
Copy link
Collaborator

@williammfu williammfu commented Jan 18, 2022

Type of changes

Please check the type of change your PR introduces:

  • Bugfix
  • Enhancement
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behaviour?

  • Request demo form does not contain a company size field for the user to fill

What is the new behavior?

  • Request demo form has a new field: company size as a dropdown from which user could choose their company size

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • I have filled the [Unreleased] Changelog

Security Pentester API Checklist

  • IDOR
  • Malicious Script Injection
  • SQL Injection

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@gregoriusjimmy gregoriusjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working

Copy link
Collaborator

@rizkybaihaqy rizkybaihaqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mantap, tp changelognya belum fu

@williammfu williammfu merged commit 1873440 into main Jan 19, 2022
@williammfu williammfu deleted the feat/new-fields branch January 19, 2022 03:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants