Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow @ and . in usernames #259

Closed
indexzero opened this issue Jun 28, 2012 · 3 comments
Closed

Allow @ and . in usernames #259

indexzero opened this issue Jun 28, 2012 · 3 comments

Comments

@indexzero
Copy link
Member

nt

@blakmatrix
Copy link
Contributor

What about * ?

got a bug submission for this... I'll separate out if we don't want to add it for a useful message for invalid characters.

User/App: marcello3d/etsy-trader 
node -v: v0.6.18 
npm -v: 1.1.21 
jitsu -v: 0.8.9

Logs:

info: Welcome to Nodejitsu marcello3d 
info: It worked if it ends with Nodejitsu ok 
info: Executing command deploy 
info: Analyzing your application dependencies in server.js 
warn: Local version appears to be old 
warn: Your package.json version will be incremented for you automatically 
warn: About to write /Volumes/Personal/Dropbox/Home/workspace/battle/package.json 
data: 
data: { 
data: author: [ 'Marcello Bastéa-Forte <marcello@cellosoft.com> (http://marcello.cellosoft.com/)', 'Roman Shtylman (http://shtylman.com/)' ], 
data: name: 'etsy*trader', 
data: version: '0.1.0-1', 
data: private: true, 
data: subdomain: 'et', 
data: dependencies: { 
data: express: '3.0.0beta4', 
data: hbs: '1.0.4', 
data: stylus: '0.27.2', 
data: sockjs: '0.3.1', 
data: request: '2.9.203' 
data: }, 
data: engines: { node: '>=0.6.0' }, 
data: scripts: { start: 'server.js' } 
data: } 
data: 
prompt: Is this ok? (yes): 
info: Creating snapshot 0.1.0-1 
error: Error running command deploy 
error: Nodejitsu Error (400): Bad Request 
info: Nodejitsu not ok

Comments:

The name "etsy*trader" results in a not-so-useful error. Changing it to "etsy-trader" fixed the problem, but it'd be nice if that were validated earlier or the was a more descriptive error message. 

@indexzero
Copy link
Member Author

@blakmatrix This is related, but not the same issue.

@jfhbrook
Copy link
Contributor

I believe this was fixed a long time ago. If not, feel free to reopen, etc.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants