Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow all chars except whitespace in usernames #5

Closed
wants to merge 1 commit into from
Closed

Allow all chars except whitespace in usernames #5

wants to merge 1 commit into from

Conversation

fb55
Copy link

@fb55 fb55 commented Aug 21, 2012

Fixes jitsu/259

@Marak
Copy link

Marak commented Aug 21, 2012

Thank you for the pull request.

Unfortunately, I think it's best to close this without merging.

The problem is that since there is no direct relationship between the expected API endpoint schema and cli-users, making specific changes to only one side will create a schema mis-match, and cause validation problems. In this case, the expected API endpoint disallows some chars in user-names.

If you need to make specific adjustments to the cli-users schema, you should be able to set values in this file at run-time ( https://github.com/flatiron/cli-users/blob/master/lib/properties.js ), without requiring forking the project / changing core code.

In the near future, there will be a better correlation of schema between all interfaces, so that you'll be able to make modifications to the schema in one place.

Hope that helps. Thanks again for the pull request.

@Marak Marak closed this Aug 21, 2012
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow @ and . in usernames
2 participants