Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track backport of v8_inspector #109

Closed
MylesBorins opened this issue May 31, 2016 · 5 comments
Closed

Track backport of v8_inspector #109

MylesBorins opened this issue May 31, 2016 · 5 comments
Labels

Comments

@MylesBorins
Copy link
Contributor

MylesBorins commented May 31, 2016

This issue is to track all commits that will be needed to track the backport of nodejs/node#6792

Other PR's that will need to be backported too

nodejs/node#7070
nodejs/node#7078
nodejs/node#7118
nodejs/node#7212
nodejs/node#7228
nodejs/node#7232
nodejs/node#7248
nodejs/node#7258

Should we make a temporary label to track these issues?

/cc @ofrobots

@Fishrock123
Copy link
Contributor

The inspector seems awfully large for a backport, are we sure we want to be doing this?

What will our messaging look like? This is a very sizable feature. Doesn't feel very lts-y at all.

@ofrobots
Copy link

ofrobots commented May 31, 2016

v6.x is not LTS yet. I don't think this issue is necessary at this point. We should track inspector support like everything else we merge into Current.

EDIT: typo.

@MylesBorins
Copy link
Contributor Author

@ofrobots I've gone through and updated the top comment with all landed PR's that have the v8_inspector label. Let me know if you think I've missed anything

@rvagg I've also gone ahead and added all of these PR's to the v7 milestone. Please let me know if you prefer them not to be added

@rvagg
Copy link
Member

rvagg commented Jun 15, 2016

Well I don't think we're going to need to do any backporting other than master -> v6.x but having a list of commits might be helpful if we end up having to back it out prior to v6 LTS for whatever reason.

@MylesBorins
Copy link
Contributor Author

everything has been backported

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants