inspector: change default port #7212
Conversation
nodejs-github-bot
added
the
c++
|
LGTM |
1 similar comment
|
LGTM |
|
@ofrobots just making sure I am reading this change correctly individuals will now be able to pass a custom port to the inspector with |
| @@ -240,7 +240,7 @@ class V8NodeInspector : public blink::V8Inspector { | |||
| bool running_nested_loop_; | |||
| }; | |||
|
|
|||
| Agent::Agent(Environment* env) : port_(9229), | |||
| Agent::Agent(Environment* env) : port_(0), | |||
There was a problem hiding this comment.
So before the instance is started it will have a port of 0?
There was a problem hiding this comment.
The port value is actually provided at the time Agent::Start is called. This happened to be the default initialization of the field and the value of 9229 was never getting used. This clean it up to be zero-initialized instead.
|
FYI 9229 is not reserved. As well as palindromic. :) |
Users can still provide a custom port with |
|
The issues on ARM in the CI look like infrastructure issues. Will land this soon. |
We should use a different default port number for the new debug protocol. This makes it easier for debuggers to guess which protocol they are expected to use to talk to a node process with a debug server. PR-URL: nodejs#7212 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
We should use a different default port number for the new debug protocol. This makes it easier for debuggers to guess which protocol they are expected to use to talk to a node process with a debug server. PR-URL: #7212 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
We should use a different default port number for the new debug
protocol. This makes it easier for debuggers to guess which protocol
they are expected to use to talk to a node process with a debug
server.