-
-
Notifications
You must be signed in to change notification settings - Fork 602
Imminent issue for chilean users (tzdata2022b) #773
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I'm looking forward for this!!!! |
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29
This updates the time zone database up to 2022b, following the documentation at https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs#44333 Refs: nodejs/Release#773
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
A workaround for existing versions of Node.js: You can set ICU4C's
e.g. $ ls /tmp/rlau/tz
metaZones.res timezoneTypes.res windowsZones.res zoneinfo64.res
$ nvm run 16 -p "new Intl.DateTimeFormat('en-US', { hour12: false, timeZone: 'America/Santiago', year: 'numeric', month: '2-digit', day: '2-digit', hour: '2-digit', minute: '2-digit', second: '2-digit', timeZoneName: 'short' }).format(new Date('2022-09-05T00:00:00Z'))"
Running node v16.17.0 (npm v8.15.0)
09/04/2022, 21:00:00 GMT-3
$ ICU_TIMEZONE_FILES_DIR=/tmp/rlau/tz nvm run 16 -p "new Intl.DateTimeFormat('en-US', { hour12: false, timeZone: 'America/Santiago', year: 'numeric', month: '2-digit', day: '2-digit', hour: '2-digit', minute: '2-digit', second: '2-digit', timeZoneName: 'short' }).format(new Date('2022-09-05T00:00:00Z'))"
Running node v16.17.0 (npm v8.15.0)
09/04/2022, 20:00:00 GMT-4
$ |
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: nodejs#44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #45094 Refs: nodejs/Release#773 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: nodejs/node#44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: nodejs/node#44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlau I believe we can close this issue now? |
I think we still haven't updated 16.x. |
The Chilean Government decided to delay the DST start from September 4 to September 11, in order to "avoid problems in election day" (we do held a plebiscite on September 4th).
Because of that, tzdata2022b was released (and now 2022c, that fixes a build-time issue). This update is critical for users that depend on having the correct time at the moment.
As I see with #576, the last couple of times this have happened, it was handled with relative quick, getting the updated the data from the icu-data repo (there is even a PR to do it automatically at nodejs/node#43988). As of now, icu-data has an open PR to update this at unicode-org/icu-data#28, and right now the data can be copied from the PR, but it should be accepted soon anyway.
Sadly, I see that the last LTS update was released just today (16.17.0). As i think this could be a critical issue, would it be possible to do a point-release in the following weeks to handle this, so it can be picked by downstream-distributions (AWS Lambda in my case)
Thanks.
The text was updated successfully, but these errors were encountered: