Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: add minutes for meeting 13 June 2018 #552

Merged
merged 3 commits into from
Jun 25, 2018

Conversation

mhdawson
Copy link
Member

No description provided.

@mhdawson
Copy link
Member Author

Raw cut/paste will look later if needs fixup or others can fixup by pushing commits.

@mhdawson
Copy link
Member Author

@nodejs/tsc still need at least one review.

namespace
* TC39 is also looking into namespaces as a language feature, advice from committee was
not to wait for it (there are no proposals now, likely more than a year out).
* Can’t just be a directory, security concern about modules that don’t have the namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be elaborated on?

* Let’s leave on the agenda.
* Anna, may make sense to ask if we have enough engagement from those outside the our
bubble.
* single sentence question -> should node namespace modules? along with context.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what are the action items here? Last time it was “wait a week and revisit”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the next action is to continue the discussion in the issue tracker. There is no clear consensus in the TSC members one way or the other. In addition, I don't think there was the consensus that we needed to rush and have a vote either as the feeling is that there is still work to be done as part of our consensus seeking model. In particular, I think I remember a request to better frame the pros/cons and move people toward a shared understanding (for example it being harder to add modules is seen but a con by some and a pro by others). If anybody else had some details on next actions to add please comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to add, the week before not enough people had reviewed the issue to have a discussion, this time there was a good discussion, but not one that resulted in a decision one way or the other or agreement it had reached the point were a vote was appropriate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm hoping to have is a TSC discussion that some kind of "non-bare" identifier is needed for all new core modules.

The details of that certainly can be hashed out in GitHub.

* Proposal for guidance on adding new APIs

* OpenSSL Evolution
* Pull request 21282, would some some additional opinion. Security issue with CVE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what that first sentence is supposed to be (would some some additional opinion should be....something else, but what?)


* Workers
* Not too much new since PR landed, may include in next 10.x release (it is behind a flag)
* incorning out minor issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorning? I'm guessing that shluld be Working?


* Proposal: add all new core modules under a scope? (too late for http2) [#389](https://github.com/nodejs/TSC/issues/389)
* Myles, we need namespaces and we need to move on faster than we have to. Every
time we add something new have have the shadowing issue with npm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have have -> we have?

* Have gotten through a larger number of the use cases
* PR open for meta require
* Starting to talk about deadlines
* Main contentious topics is about transparent interop, module specifier resolution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is -> are

* Starting to talk about deadlines
* Main contentious topics is about transparent interop, module specifier resolution
* Package name maps proposal from Domenic, to allow install time tooling to generate
manifest to be consume by browser to allow bare imports. May provide path to being
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consume -> consumed

* Jeremiah only move to namespaces once. Also align with returning promisified APIs.
* Myles that could be a 11/2 year to 2 years from now.
* Let’s leave on the agenda.
* Anna, may make sense to ask if we have enough engagement from those outside the our
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the our -> our

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of nits, but I'm OK with this landing with or without them addressed. @ljharb's questions should be answered, but that can happen in the comments here rather than in the doc itself. (Probably better if it's in the doc itself.)

(Basically, taking minutes is a thankless job so I'm not going to demand ccorrections/improvements. These minutes as they are stand as an improvement over what we have now, which is no notes at all.)

* TC39 is also looking into namespaces as a language feature, advice from committee was
not to wait for it (there are no proposals now, likely more than a year out).
* Can’t just be a directory, security concern about versions that don’t have the namespace as
people coule publish modules with the same name in those versions and they could be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not, in fact, any more of a concern than new bare core modules - a namespace on npm is a user - and node would own whatever user it was, so it would be impossible for anyone to publish a module under that namespace.

@Trott Trott merged commit 6ab821e into nodejs:master Jun 25, 2018
@mhdawson mhdawson deleted the meeting13June branch August 14, 2019 17:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants