Skip to content

Napi version in node-gyp #371

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
mhdawson opened this issue May 9, 2019 · 5 comments
Closed

Napi version in node-gyp #371

mhdawson opened this issue May 9, 2019 · 5 comments
Milestone
Milestone 11

Comments

@mhdawson
Copy link
Member

mhdawson commented May 9, 2019

For discussion in next meeting:

nodejs/node-gyp#1745
@mhdawson mhdawson added this to the Milestone 11 milestone May 9, 2019
@jschlight
Copy link
Collaborator

With node-pre-gyp and prebuild, the N-API version is essentially specified by the user and then the actual N-API version being built against is communicated into the binding.gyp file using a new napi-build-version variable we created for the purpose.

In the linked issue, the user is requesting that node-gyp inform the binding.gyp file which N-API version is supported by the version of Node being built against.

It's like the opposite of what we implemented for node-pre-gyp and prebuild.

@NickNaso NickNaso mentioned this issue May 21, 2019
Closed
2 tasks
@richardlau
Copy link
Member

A PR was opened against core: nodejs/node#27800

@NickNaso NickNaso mentioned this issue May 23, 2019
Closed
4 tasks
@NickNaso
Copy link
Member

Hi everyone,
I closed my previous PR and reopened new one nodejs/node#27835. Please if you have time take a look.

@NickNaso
Copy link
Member

NickNaso commented Jun 7, 2019

Hi everyone,
if someone has time could take a look at this PR nodejs/node#27835 in particular the last two comments? I need a feedback.

pull bot pushed a commit to SimenB/node that referenced this issue Jul 2, 2019
@NickNaso
build: expose napi_build_version variable
9868126 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: nodejs#27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 2, 2019
@NickNaso @targos
build: expose napi_build_version variable
9b735b1 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Jul 2, 2019
@NickNaso @targos
build: expose napi_build_version variable
cd71aad 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@NickNaso
Copy link
Member

NickNaso commented Jul 3, 2019

I’m closing this because the PR has been landed yesterday and the work now is on Node.js 12.6.0

@NickNaso NickNaso closed this as completed Jul 3, 2019
@gabrielschulhof gabrielschulhof mentioned this issue Sep 19, 2020
Closed
4 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Sep 19, 2020
@NickNaso
build: expose napi_build_version variable
248df1b 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: nodejs#27835
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau pushed a commit to nodejs/node that referenced this issue Oct 7, 2020
@NickNaso @richardlau
build: expose napi_build_version variable
b83f9a5 
Expose `napi_build_version` to allow `node-gyp` to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Backport-PR-URL: #35266
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
4 participants
@NickNaso @richardlau @mhdawson @jschlight