Skip to content

napi: change napi_instanceof() to use Symbol.hasInstance #185

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2017
Merged

napi: change napi_instanceof() to use Symbol.hasInstance #185

merged 1 commit into from
Mar 23, 2017

Conversation

gabrielschulhof
Copy link
Collaborator

Fixes #182

gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this pull request Mar 22, 2017
napi: change napi_instanceof() to use Symbol.hasInstance
ccee0af 
Re nodejs/node#11975 (comment)
Fixes nodejs#182
Closes nodejs#185
boingoing

This comment was marked as off-topic.

# to view

jasongin

This comment was marked as off-topic.

# to view

@gabrielschulhof
Copy link
Collaborator Author

https://ci.nodejs.org/view/All/job/node-test-commit-linux-abi/80/

gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this pull request Mar 23, 2017
napi: change napi_instanceof() to use Symbol.hasInstance
bf6fa74 
Re nodejs/node#11975 (comment)
Fixes nodejs#182
Closes nodejs#185
@gabrielschulhof
Copy link
Collaborator Author

https://ci.nodejs.org/view/All/job/node-test-commit-linux-abi/82/

@gabrielschulhof
Copy link
Collaborator Author

@jasongin and @boingoing could you please take another look?

@gabrielschulhof
Copy link
Collaborator Author

I realized I wasn't actually asserting the checks affected by Symbol.hasInstance. I have now fixed that.

https://ci.nodejs.org/view/All/job/node-test-commit-linux-abi/86/

@gabrielschulhof
Copy link
Collaborator Author

... along with a build warning in test/addons-napi/test_buffer.c.

jasongin

This comment was marked as off-topic.

# to view

boingoing

This comment was marked as off-topic.

# to view

boingoing

This comment was marked as off-topic.

# to view

@gabrielschulhof gabrielschulhof merged commit c379d22 into nodejs:api-prototype-8.x Mar 23, 2017
@gabrielschulhof gabrielschulhof deleted the use-symbol-instanceof branch March 23, 2017 19:13
jasongin pushed a commit to jasongin/nodejs that referenced this pull request Mar 23, 2017
@jasongin
napi: change napi_instanceof() to use Symbol.hasInstance
1427b33 
Re nodejs#11975 (comment)
Fixes nodejs/abi-stable-node#182
Closes nodejs/abi-stable-node#185
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasongin jasongin jasongin approved these changes

+1 more reviewer

@boingoing boingoing boingoing approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielschulhof @boingoing @jasongin