Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: make MDN links to global classes more consistent #190

Merged
merged 1 commit into from
Feb 7, 2025
Merged

doc: make MDN links to global classes more consistent #190

merged 1 commit into from
Feb 7, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 6, 2025

Refs: nodejs/node#56922

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I've covered new added functionality with unit tests if necessary.

@aduh95 aduh95 requested a review from a team as a code owner February 6, 2025 11:18
AugustinMauroy
AugustinMauroy approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@aduh95 aduh95 merged commit 3452cf2 into main Feb 7, 2025
7 checks passed
@aduh95 aduh95 deleted the aduh95-mdn-links branch February 7, 2025 17:57
@ovflowd
Copy link
Member

ovflowd commented Feb 7, 2025

Thanks, @aduh95 do you think our map haw any other link that might be missing? I try to keep it updated from time to time until we do the switch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@flakey5 flakey5 flakey5 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @ovflowd @flakey5 @AugustinMauroy