Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: don't set YARN_IGNORE_ENGINES env variable #830

Closed
wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

This partially reverts c3917aa.
yarn v2 does not support the YARN_IGNORE_ENGINES option.

Fixes: #824

Checklist
  • npm test passes
  • tests are included
  • contribution guidelines followed
    here

This partially reverts c3917aa.
yarn v2 does not support the YARN_IGNORE_ENGINES option.

Fixes: nodejs#824
@richardlau
Copy link
Member Author

richardlau commented Sep 25, 2020

Test citgm-smoker run against nodejs/node master to see if we still need to set YARN_IGNORE_ENGINES for any of the modules in the lookup: https://ci.nodejs.org/job/citgm-smoker/2480/

@richardlau
Copy link
Member Author

Looks like we will need to set the environment variable still, e.g. https://ci.nodejs.org/job/citgm-smoker/2480/nodes=rhel7-s390x/testReport/junit/(root)/citgm/pug_v3_0_0/

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #830 into main will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   96.08%   96.05%   -0.04%     
==========================================
  Files          30       31       +1     
  Lines         894      912      +18     
==========================================
+ Hits          859      876      +17     
- Misses         35       36       +1     
Impacted Files Coverage Δ
lib/create-options.js 100.00% <ø> (ø)
lib/citgm.js 100.00% <0.00%> (ø)
test/fixtures/omg-i-timeout/test.js 94.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526c1f5...2394caa. Read the comment docs.

@richardlau
Copy link
Member Author

Requested another CI (using nodejs/node#35332 to avoid the umask deprecation noise): https://ci.nodejs.org/job/citgm-smoker/2481/

@richardlau
Copy link
Member Author

This isn't going to work. Need a different approach.

@richardlau richardlau closed this Sep 25, 2020
@richardlau richardlau deleted the yarn branch September 25, 2020 17:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-jest v24.0.0 broken on CI
2 participants