Add i386 arch support #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags: 4.8.5-alpine, 4.8-alpine, 4-alpine, argon-alpine
-Architectures: amd64
+Architectures: amd64, i386These won't do 😉 |
|
Not for any alpines, or just alpine 3.4 (meaning node 4 and 6)? |
|
Diffs look OK, just need to remove |
|
Diff: diff --git i/library/node w/library/node
index 1c45afca..3f209ca7 100644
--- i/library/node
+++ w/library/node
@@ -4,28 +4,28 @@ Maintainers: The Node.js Docker Team <https://github.com/nodejs/docker-node> (@n
GitRepo: https://github.com/nodejs/docker-node.git
Tags: 9.0.0, 9.0, 9, latest
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 9.0
Tags: 9.0.0-alpine, 9.0-alpine, 9-alpine, alpine
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6, i386
GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0/alpine
Tags: 9.0.0-onbuild, 9.0-onbuild, 9-onbuild, onbuild
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0/onbuild
Tags: 9.0.0-slim, 9.0-slim, 9-slim, slim
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 9.0/slim
Tags: 9.0.0-stretch, 9.0-stretch, 9-stretch, stretch
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 9.0/stretch
Tags: 9.0.0-wheezy, 9.0-wheezy, 9-wheezy, wheezy
@@ -34,28 +34,28 @@ GitCommit: 092306f6d035d53d7f087a1a671915aabc946c6f
Directory: 9.0/wheezy
Tags: 8.9.0, 8.9, 8, carbon
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 8.9
Tags: 8.9.0-alpine, 8.9-alpine, 8-alpine, carbon-alpine
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v6, i386
GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9/alpine
Tags: 8.9.0-onbuild, 8.9-onbuild, 8-onbuild, carbon-onbuild
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9/onbuild
Tags: 8.9.0-slim, 8.9-slim, 8-slim, carbon-slim
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 8.9/slim
Tags: 8.9.0-stretch, 8.9-stretch, 8-stretch, carbon-stretch
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 8.9/stretch
Tags: 8.9.0-wheezy, 8.9-wheezy, 8-wheezy, carbon-wheezy
@@ -64,8 +64,8 @@ GitCommit: 39a5c8a3be7fff2ddc67a2e72919d0a3841b235f
Directory: 8.9/wheezy
Tags: 6.11.5, 6.11, 6, boron
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 222c645bfa57e415d57fc4ac2088262c8c3cef70
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: 1ce9e890c6a93f64e1a5df148960d21206cf9fcd
Directory: 6.11
Tags: 6.11.5-alpine, 6.11-alpine, 6-alpine, boron-alpine
@@ -74,18 +74,18 @@ GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 6.11/alpine
Tags: 6.11.5-onbuild, 6.11-onbuild, 6-onbuild, boron-onbuild
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
GitCommit: 7701eea6fe125530894b3e83f1e9d385e9ee509f
Directory: 6.11/onbuild
Tags: 6.11.5-slim, 6.11-slim, 6-slim, boron-slim
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 6.11/slim
Tags: 6.11.5-stretch, 6.11-stretch, 6-stretch, boron-stretch
-Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+Architectures: amd64, ppc64le, s390x, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 6.11/stretch
Tags: 6.11.5-wheezy, 6.11-wheezy, 6-wheezy, boron-wheezy
@@ -94,8 +94,8 @@ GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 6.11/wheezy
Tags: 4.8.5, 4.8, 4, argon
-Architectures: amd64, ppc64le, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+Architectures: amd64, ppc64le, arm64v8, arm32v7, i386
+GitCommit: 1ce9e890c6a93f64e1a5df148960d21206cf9fcd
Directory: 4.8
Tags: 4.8.5-alpine, 4.8-alpine, 4-alpine, argon-alpine
@@ -104,18 +104,18 @@ GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
Directory: 4.8/alpine
Tags: 4.8.5-onbuild, 4.8-onbuild, 4-onbuild, argon-onbuild
-Architectures: amd64, ppc64le, arm64v8, arm32v7
+Architectures: amd64, ppc64le, arm64v8, arm32v7, i386
GitCommit: 7701eea6fe125530894b3e83f1e9d385e9ee509f
Directory: 4.8/onbuild
Tags: 4.8.5-slim, 4.8-slim, 4-slim, argon-slim
-Architectures: amd64, ppc64le, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+Architectures: amd64, ppc64le, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 4.8/slim
Tags: 4.8.5-stretch, 4.8-stretch, 4-stretch, argon-stretch
-Architectures: amd64, ppc64le, arm64v8, arm32v7
-GitCommit: 94a739297fcd60ef969b478d4e581a6d8299a94d
+Architectures: amd64, ppc64le, arm64v8, arm32v7, i386
+GitCommit: bf48e44dca420c3e68f865b5f6697ed74d80ce9d
Directory: 4.8/stretch
Tags: 4.8.5-wheezy, 4.8-wheezy, 4-wheezy, argon-wheezy |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Awesome 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574. I'm pretty sure this is correct, but not 100%. Wheezy not included because of #567.
Diff for stackbrew:
/cc @tianon