Skip to content

fix(msvs): avoid fixing path for arguments with "=" #143

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

targos
Copy link
Member

@targos targos commented Apr 6, 2022

They are probably not paths, and V8 uses an argument like that, so the
fix is needed in Node.js

Refs: nodejs/node#42115

They are probably not paths, and V8 uses an argument like that, so the
fix is needed in Node.js

Refs: nodejs/node#42115
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit 7e8f16e into nodejs:main Apr 6, 2022
@targos targos deleted the fix-fix-path branch April 6, 2022 08:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants