Skip to content

chore: sort CHANGELOG references in ASCII order #67

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: sort CHANGELOG references in ASCII order #67

wants to merge 1 commit into from

Conversation

aduh95
Copy link

@aduh95 aduh95 commented Sep 30, 2020

@targos
Copy link
Member

targos commented Sep 30, 2020

I disagree with this change. Node.js should not validate the format of external dependencies and the order here should follow that of the headers.

@aduh95
Copy link
Author

aduh95 commented Sep 30, 2020

OK, I didn't know GYP was still considered an external dependency.

@aduh95 aduh95 closed this Sep 30, 2020
@aduh95 aduh95 deleted the patch-1 branch September 30, 2020 09:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduh95 @targos