Skip to content

Commit

Permalink
Fix compatibility with Python >= 3.12 (#987)
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss authored Feb 13, 2025
1 parent 475ef4f commit b5d90f1
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 1 deletion.
54 changes: 54 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
# https://github.com/actions/setup-node
# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

name: ci
on:
push:
# branches: [main]
pull_request:
# branches: [main]
workflow_dispatch:
permissions:
contents: read
jobs:
ci:
strategy:
fail-fast: false
matrix: # TODO: Enable 23.x after nodejs/nan#979 or similar.
node-version: [22.x, 21.x, 20.x, 19.x, 18.x, 17.x, 16.x]
os: [windows-latest]
include:
- node-version: lts/*
os: macos-13 # macOS on Intel
- node-version: lts/*
os: macos-latest # macOS on arm64
- node-version: lts/*
os: ubuntu-latest # Linux on x64
- node-version: lts/*
os: ubuntu-24.04-arm # Linux on arm64
- node-version: lts/*
os: windows-2025
- node-version: 14.x
os: windows-2019
- node-version: 13.x
os: windows-2019
- node-version: 12.x
os: windows-2019
- node-version: 10.x
os: windows-2019
- node-version: 8.x
os: windows-2019
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
# TODO: On Windows Node.js v11 these will fail but `make test` will succeed
- if: matrix.node-version != '11.x'
run: |
npm run-script rebuild-tests
npm test
- run: make test
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"commander": "^2.8.1",
"glob": "^5.0.14",
"request": "=2.81.0",
"node-gyp": "~8.4.1",
"node-gyp": "~v10.3.1",
"readable-stream": "^2.1.4",
"tap": "~0.7.1",
"xtend": "~4.0.0"
Expand Down

0 comments on commit b5d90f1

Please # to comment.