Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: release v8.2.0 #1571

Merged
merged 1 commit into from
Sep 30, 2024
Merged

chore: release v8.2.0 #1571

merged 1 commit into from
Sep 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2024 •
edited
Loading

🤖 I have created a release beep boop

8.2.0 (2024-09-19)

Features

  • add support for nogc types via BasicEnv (#1514) (b4aeecb)
  • add support for requiring basic finalizers (#1568) (7bcb826)

Bug Fixes

  • call base basic finalizer if none defined (#1574) (294a43f)

This PR was generated with Release Please. See documentation.

@NickNaso
Copy link
Member

NickNaso commented Sep 4, 2024 •
edited
Loading

CI:

Version Job Status
main https://ci.nodejs.org/job/node-test-node-addon-api-new/9280/ X
v22.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9281/ X
v20.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9282/ X
v18.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9283/ X

It seems that thare are some failures on CI like repoterd by @mhdawson here: #1573

NickNaso
NickNaso reviewed Sep 4, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,12 @@
# node-addon-api Changelog

## [8.2.0](https://github.com/nodejs/node-addon-api/compare/v8.1.0...v8.2.0) (2024-09-04)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds , @KevinEady

@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch from 3819c40 to 7480576 Compare September 5, 2024 17:27
@KevinEady
Copy link
Contributor

I would like #1568 landed prior to release

@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2024

@NickNaso looks like we got an all green run on Sep 7 - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/2311/

@NickNaso
Copy link
Member

NickNaso commented Sep 9, 2024

@NickNaso looks like we got an all green run on Sep 7 - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/2311/

Yes, you're right, for me it's ok. i don't know if @KevinEady would like to land the PR #1568 before to meke the release.

@KevinEady
Copy link
Contributor

@mhdawson @NickNaso I've addressed the changes on Gabe's review of #1568 so just waiting for a re-approval and/or merge

@github-actions github-actions bot force-pushed the release-please--branches--main--components--node-addon-api branch from 7480576 to 247824f Compare September 19, 2024 16:02
@KevinEady
Copy link
Contributor

Hi @NickNaso @mhdawson I think this is ready to land and release? The bot updated the changelog to add the "require basic finalizers" pr.

@NickNaso
Copy link
Member

NickNaso commented Sep 20, 2024 •
edited
Loading

Hi @NickNaso @mhdawson I think this is ready to land and release? The bot updated the changelog to add the "require basic finalizers" pr.

One last pass on the CI.
CI:

Version Job Status
main https://ci.nodejs.org/job/node-test-node-addon-api-new/9355/ ✅
v22.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9356/ ✅
v20.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9357/ ✅
v18.x https://ci.nodejs.org/job/node-test-node-addon-api-new/9358/ ✅

mhdawson
mhdawson approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing the release!

@legendecas legendecas merged commit 5b1a57d into main Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

🤖 Created releases:

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@legendecas legendecas legendecas approved these changes

@KevinEady KevinEady KevinEady approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
autorelease: tagged
Projects
Node-API Team Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickNaso @KevinEady @mhdawson @legendecas