Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Broken git node release --prepare? #686

Closed
targos opened this issue Mar 14, 2023 · 4 comments
Closed

Broken git node release --prepare? #686

targos opened this issue Mar 14, 2023 · 4 comments

Comments

@targos
Copy link
Member

targos commented Mar 14, 2023

Not sure when it started, but it seems that the command now generates an invalid changelog file:

  • Wrong format for the list of commits
  • Doesn't update the versions table in CHANGELOG_Vx.md

Maybe related to #669
Refs: nodejs/node#47087

@VoltrexKeyva
Copy link
Member

VoltrexKeyva commented Mar 14, 2023

Wrong format for the list of commits

I don't see anything wrong with the generated list of commits in the referenced PR, am I missing something?

@targos
Copy link
Member Author

targos commented Mar 14, 2023

@richardlau
Copy link
Member

Not sure when it started, but it seems that the command now generates an invalid changelog file:

  • Wrong format for the list of commits

Maybe related to #669 Refs: nodejs/node#47087

Most likely. That PR updated changelog-maker -- changelog-maker@3 changed the default output format: nodejs/changelog-maker#121.

@RafaelGSS
Copy link
Member

Just opened two PRs that address this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants