Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update deps and dev deps #669

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Feb 25, 2023

  • Update the dependencies and developer dependencies to their latest versions.
  • Remove the rimraf dependency in favor of the built-in fs.rmSync() method.
  • Remove deprecated eslint-plugin-standard developer dependency as it's no longer needed.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 83.42% // Head: 83.41% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4b573bf) compared to base (01d10df).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   83.42%   83.41%   -0.01%     
==========================================
  Files          37       37              
  Lines        4138     4136       -2     
==========================================
- Hits         3452     3450       -2     
  Misses        686      686              
Impacted Files Coverage Δ
lib/auth.js 87.39% <100.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a review of the deps, only ghauth needs to be addressed in this PR, rest of the comments are notes for later.

"listr2": "^4.0.5",
"ghauth": "^5.0.1",
"inquirer": "^9.1.4",
"listr2": "^5.0.7",
"lodash": "^4.17.21",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for a future PR: removing lodash would be nice

"which": "^2.0.2",
"yargs": "^17.5.0"
"which": "^3.0.0",
"yargs": "^17.7.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for a future PR: it'd be nice to switch to util.parseArgs (but that's likely not a lightway task, it's also fine to keep yargs)

- Update the dependencies and developer dependencies to their latest
versions.
- Remove the `rimraf` dependency in favor of the built-in
`fs.rmSync()` method.
- Remove deprecated `eslint-plugin-standard` developer dependency as
it's no longer needed.
@aduh95 aduh95 merged commit 6926407 into nodejs:main Feb 26, 2023
@VoltrexKeyva VoltrexKeyva deleted the update-deps branch February 26, 2023 16:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants