-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: update deps and dev deps #669
Conversation
Codecov ReportBase: 83.42% // Head: 83.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 83.42% 83.41% -0.01%
==========================================
Files 37 37
Lines 4138 4136 -2
==========================================
- Hits 3452 3450 -2
Misses 686 686
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dbe408d
to
596d310
Compare
596d310
to
8e326c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a review of the deps, only ghauth
needs to be addressed in this PR, rest of the comments are notes for later.
"listr2": "^4.0.5", | ||
"ghauth": "^5.0.1", | ||
"inquirer": "^9.1.4", | ||
"listr2": "^5.0.7", | ||
"lodash": "^4.17.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for a future PR: removing lodash
would be nice
"which": "^2.0.2", | ||
"yargs": "^17.5.0" | ||
"which": "^3.0.0", | ||
"yargs": "^17.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for a future PR: it'd be nice to switch to util.parseArgs
(but that's likely not a lightway task, it's also fine to keep yargs)
- Update the dependencies and developer dependencies to their latest versions. - Remove the `rimraf` dependency in favor of the built-in `fs.rmSync()` method. - Remove deprecated `eslint-plugin-standard` developer dependency as it's no longer needed.
8e326c0
to
4b573bf
Compare
rimraf
dependency in favor of the built-infs.rmSync()
method.eslint-plugin-standard
developer dependency as it's no longer needed.