-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: create security release command #715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
267edde
to
d30a3d7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 83.38% 83.03% -0.36%
==========================================
Files 37 37
Lines 4158 4178 +20
==========================================
+ Hits 3467 3469 +2
- Misses 691 709 +18
☔ View full report in Codecov by Sentry. |
ping @nodejs/security-release |
aduh95
reviewed
Aug 17, 2023
aduh95
reviewed
Aug 17, 2023
bdcb455
to
0b871f5
Compare
0b871f5
to
33d82be
Compare
Done @aduh95. Could you please re-review? |
aduh95
reviewed
Sep 16, 2023
aduh95
reviewed
Sep 16, 2023
aduh95
approved these changes
Sep 17, 2023
21c641b
to
7172d72
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new command should manage all the states of a security release. This PR includes the
CREATE
and should be followed by other PRs to manage the next steps, such as requesting CVEs, creating issues, sending emails and so on.Example this is action: https://github.com/nodejs-private/node-private/issues/443