Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: create security release command #715

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

RafaelGSS
Copy link
Member

This new command should manage all the states of a security release. This PR includes the CREATE and should be followed by other PRs to manage the next steps, such as requesting CVEs, creating issues, sending emails and so on.

Example this is action: https://github.com/nodejs-private/node-private/issues/443

@RafaelGSS RafaelGSS force-pushed the create-security-release branch from 267edde to d30a3d7 Compare July 10, 2023 01:41
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.36% ⚠️

Comparison is base (4b2b6fa) 83.38% compared to head (7172d72) 83.03%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   83.38%   83.03%   -0.36%     
==========================================
  Files          37       37              
  Lines        4158     4178      +20     
==========================================
+ Hits         3467     3469       +2     
- Misses        691      709      +18     
Files Changed Coverage Δ
lib/auth.js 79.69% <14.28%> (-7.70%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RafaelGSS RafaelGSS changed the title lib: create security release command feat: create security release command Jul 10, 2023
@RafaelGSS RafaelGSS requested a review from ruyadorno July 14, 2023 00:37
@RafaelGSS
Copy link
Member Author

ping @nodejs/security-release

@RafaelGSS
Copy link
Member Author

ping @nodejs/releasers

image

@RafaelGSS RafaelGSS force-pushed the create-security-release branch 3 times, most recently from bdcb455 to 0b871f5 Compare September 7, 2023 19:59
@RafaelGSS RafaelGSS force-pushed the create-security-release branch from 0b871f5 to 33d82be Compare September 15, 2023 23:32
@RafaelGSS RafaelGSS requested a review from aduh95 September 15, 2023 23:33
@RafaelGSS
Copy link
Member Author

Done @aduh95. Could you please re-review?

@RafaelGSS RafaelGSS requested a review from aduh95 September 17, 2023 07:19
@RafaelGSS RafaelGSS force-pushed the create-security-release branch from 21c641b to 7172d72 Compare September 19, 2023 13:47
@RafaelGSS RafaelGSS merged commit 6d68c99 into nodejs:main Sep 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants