Skip to content

build: raise the minimum Python version from 2.6 to 2.7 #1818

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: raise the minimum Python version from 2.6 to 2.7 #1818

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 11, 2019 •
edited
Loading

As discussed in #1811, this change aligns our code with our docs.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Raise the minimum acceptable Python version from 2.6 to 2.7.

@nodejs/python

@cclauss cclauss added the Python label Jul 11, 2019
joaocgreis
joaocgreis approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already marked semver-major, I think we can do this.

rvagg pushed a commit that referenced this pull request Jul 15, 2019
@cclauss @rvagg
lib: raise the minimum Python version from 2.6 to 2.7
9db85ed 
As discussed in #1811

PR-URL: #1818
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
rvagg
rvagg approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved and landed in 9db85ed

@rvagg rvagg closed this Jul 15, 2019
@rvagg rvagg deleted the Minimum-Python-is-2.7 branch July 15, 2019 05:11
@rvagg
Copy link
Member

rvagg commented Jul 15, 2019

@cclauss if you use this repo for your branches, consider prefixing them with your name. It makes it easier to see who's doing what and what might be deleteable: cclauss/Minimum-Python-is-2.7.

@rvagg rvagg mentioned this pull request Jul 16, 2019
Merged
rvagg pushed a commit that referenced this pull request Jul 17, 2019
@cclauss @rvagg
lib: raise the minimum Python version from 2.6 to 2.7
c6e3b65 
As discussed in #1811

PR-URL: #1818
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@rvagg
Copy link
Member

rvagg commented Jul 17, 2019

this commit became c6e3b65 when I reordered for the v5.0.3 release as per #1829

This was referenced Sep 26, 2019
Closed
Closed
@rvagg rvagg mentioned this pull request Nov 18, 2019
Closed
@rvagg rvagg mentioned this pull request Feb 3, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joaocgreis joaocgreis joaocgreis approved these changes

@rvagg rvagg rvagg approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
Python semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @rvagg @joaocgreis @richardlau