-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix install: add iojs support #669
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
👍 though also fixed in #564 ... |
I think node-gyp is broken also with iojs@3.0, @gabeio @coderaiser can you take a look here paulmillr/chokidar#329? |
@iamstarkov I am having build issues with iojs 3 also... |
|
||
if (!distUrl) { | ||
if (semver.satisfies(version, '>=1.0.0')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not reliable if NodeJS released v1.0.0
someday, I prefer process.release.node === 'io.js'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Node.js" 1.0.0 will never be released. As a TSC member, I can authoritatively say that. :)
Also, io.js is node.js now: https://github.com/nodejs/node
However, version detection still isn't a great way of doing things, though it could for for io.js 1.0.0> <3.0.0
. As @camsong said, what we really should be doing now is detecting 3.0.0's process.release
:)
As a workaround, you can build against electron and end up with binaries that also load into vanilla iojs:
The last command runs a script in the electron-updater-tools project that uses a I ideally this would be fixed in node-gyp directly. Also related to this PR: #653 |
Nice @justinmchase! |
Superseded by #711. |
Add
iojs
support: when version>=1.0.0
download dist from urlhttps://iojs.org
.