Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Address regressions due to changes in node #67

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented May 16, 2019

  • Handle switch to file URLs
  • Handle change in sourceText formatting (different new lines, no more CJS wrapper)
  • Handle change in step behavior (there is no more break step at the beginning of the CJS wrapper function)

To clean up the breakpoint matching, I pulled that regex into a dedicated helper in the test harness for launching the CLI.

@jkrems jkrems force-pushed the jkrems/feature/master/fix-test branch from 0fba6a0 to cc4da57 Compare May 30, 2019 09:04
@jkrems jkrems force-pushed the jkrems/feature/master/fix-test branch from cc4da57 to 5b3511e Compare May 30, 2019 09:05
@jkrems
Copy link
Collaborator Author

jkrems commented May 30, 2019

Both nvm exec 10 npm t and nvm exec 12 npm t now pass which should be good enough (and at the very least is a big improvement).

@jkrems jkrems changed the title [WIP] Address regressions due to changes in node Address regressions due to changes in node May 30, 2019
@jkrems
Copy link
Collaborator Author

jkrems commented May 30, 2019

/cc @nodejs/diagnostics

@jkrems
Copy link
Collaborator Author

jkrems commented May 30, 2019

This seems like a good opportunity to a) enable these tests in the node CI runs and/or b) update the status of node-inspect in the diagnostics tool status MD file.

@jkrems jkrems merged commit 68035a6 into master Jun 2, 2019
@jkrems jkrems deleted the jkrems/feature/master/fix-test branch June 2, 2019 20:42
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants