Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Deprecate binary string encoding #3242

Closed
piscisaureus opened this issue May 9, 2012 · 3 comments
Closed

Deprecate binary string encoding #3242

piscisaureus opened this issue May 9, 2012 · 3 comments
Labels

Comments

@piscisaureus
Copy link

Otherwise people will keep doing crazy shit like this: https://github.com/purplefox/vert.x/blob/be58836343e02d480be1aef56b07edcd52dea8c5/src/examples/java/httpperf/nodejs-server.js

@piscisaureus
Copy link
Author

@isaacs @ry Agree?

@TooTallNate
Copy link

"binary" has been deprecated in the docs at least for ages, I think before v0.2!

binary - This encoding method is deprecated and should be avoided in favor of Buffer objects where possible. This encoding will be removed in future versions of Node.

@isaacs
Copy link

isaacs commented May 9, 2012

Hm, we do deprecate it in the docs. Let's print a warning in 0.8, remove it entirely in 0.9.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants