This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
repl: fix tab completion for a non-global context #25382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a context is not an instance of 'Context' from v0.11.7
|
LGTM. I think this should go into the 0.12 branch. I haven't tested, but this is likely an issue on io.js as well. I think this has been slipping through the cracks because the failed assertions are not being properly reported. To see what I'm talking about, check out cjihrig/node@42e7963. |
|
LGTM. Landing in v0.12 makes sense. |
Closed
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 25, 2015
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: #2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a context is not an instance of 'Context' from v0.11.7