Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

debugger: exit process on repl exit #2958

Closed
wants to merge 3 commits into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Mar 18, 2012

  • When entering repl - clone 'SIGINT' listeners array (instead of using
    existing), as it will be spliced in .removeAllListeners() call later.

Please review.

@@ -1632,6 +1647,9 @@ Interface.prototype.trySpawn = function(cb) {
self.client = null;
self.killChild();
});

cb && cb();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use if (cb) here.

indutny added 3 commits March 19, 2012 22:14
* When entering repl - clone 'SIGINT' listeners array (instead of using
existing), as it will be spliced in .removeAllListeners() call later.
* It was displaying useless warning
Do not break automatically on exception, fixes nodejs#2926
@indutny
Copy link
Member Author

indutny commented Mar 19, 2012

landed in f61d4b7, 7418905 and b6cb6ce

@indutny indutny closed this Mar 19, 2012
richardlau pushed a commit to ibmruntimes/node that referenced this pull request Sep 23, 2015
Notable changes

* buffer: Fixed a bug introduced in v4.1.0 where allocating a new
  zero-length buffer can result in the next allocation of a TypedArray
  in JavaScript not being zero-filled. In certain circumstances this
  could result in data leakage via reuse of memory space in
  TypedArrays, breaking the normally safe assumption that TypedArrays
  should be always zero-filled. (Trevor Norris) nodejs#2931.
* http: Guard against response-splitting of HTTP trailing headers
  added via response.addTrailers() by removing new-line ([\r\n])
  characters from values. Note that standard header values are already
  stripped of new-line characters. The expected security impact is low
  because trailing headers are rarely used. (Ben Noordhuis) nodejs#2945.
* npm: Upgrade to npm 2.14.4 from 2.14.3, see release notes for full
  details (Kat Marchán) nodejs#2958
  - Upgrades graceful-fs on multiple dependencies to no longer rely on
    monkey-patching fs
  - Fix npm link for pre-release / RC builds of Node
* v8: Update post-mortem metadata to allow post-mortem debugging tools
  to find and inspect:
  - JavaScript objects that use dictionary properties
    (Julien Gilli) nodejs#2959
  - ScopeInfo and thus closures (Julien Gilli) nodejs#2974
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants