This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Server.listen({ fd: number }) #3422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review, please. |
|
LGTM but I can't get it to apply against the current master (09be360). |
|
This landed in e733dc3. |
4 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
net.Server.prototype.listen({ fd: <number> }), where<number>is some arbitrary file descriptor that has already been bound and is listening.The tests take advantage of the child process stdio refactoring.
Split into 4 commits for easy review. (We ought to squash before merging.)
Fixes #3388