Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Make crypto accept and emit buffers #3571

Closed
wants to merge 1 commit into from

Conversation

thiagoarrais
Copy link

Pull request rebased to current master. Only minor modifications were needed.

Fixes #1393

@jcayzac
Copy link

jcayzac commented Jul 1, 2012

I find 'binary' and null quite redundant and confusing. Shouldn't it just return a buffer if encoding is set to 'binary' ?

@thiagoarrais
Copy link
Author

I agree (I would even say that binary encoding should be ditched altogether in favor of buffers), but there is an issue with backwards compatibility.

@langpavel
Copy link

@thiagoarrais
You can now use pseudo 'buffer' encoding in crypto

@bnoordhuis Close?

@indutny
Copy link
Member

indutny commented Oct 1, 2012

I'll close it, it's irrelevant now.

@indutny indutny closed this Oct 1, 2012
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants