Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

node.cc: break on uncaught exceptions #5713

Closed
wants to merge 2 commits into from
Closed

node.cc: break on uncaught exceptions #5713

wants to merge 2 commits into from

Commits on Jun 25, 2013

  1. node.cc: break on uncaught exception

    Most TryCatch blocks have SetVerbose flag on, this tells V8 to report
    uncaught exceptions to debugger.
    
    FatalException handler is called from V8 Message listener instead from
    the place where TryCatch was used. Otherwise uncaught exceptions are logged
    twice.
    
    See comment in `deps/v8/include/v8.h` for explanation of SetVerbose flag:
    >  By default, exceptions that are caught by an external exception
    >  handler are not reported.  Call SetVerbose with true on an
    >  external exception handler to have exceptions caught by the
    >  handler reported as if they were not caught.
    
    The flag is used by `Isolate::ShouldReportException()`, which is called
    by `Isolate::DoThrow()` to decide whether an exception is considered
    uncaught.
    bajtos committed Jun 25, 2013
    Configuration menu
    Copy the full SHA
    218d4c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2013

  1. fixup! code cleanup

    Fixed issues pointed out in the code review.
    bajtos committed Jun 26, 2013
    Configuration menu
    Copy the full SHA
    1ebae5c View commit details
    Browse the repository at this point in the history