Skip to content

Commit 0b3f5ac

Browse files
bnoordhuisdanielleadams
authored andcommitted
tools: don't gitignore base64 config.h
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638 PR-URL: #48174 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 8359582 commit 0b3f5ac

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tools/dep_updaters/update-base64.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,11 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/"
5757

5858
# Build configuration is handled by `deps/base64/base64.gyp`, but since `config.h` has to be present for the build
5959
# to work, we create it and leave it empty.
60-
echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h"
60+
echo "// Intentionally empty" > "$DEPS_DIR/base64/base64/lib/config.h"
61+
62+
# Clear out .gitignore, otherwise config.h is ignored. That's dangerous when
63+
# people check in our tarballs into source control and run `git clean`.
64+
echo "# Intentionally empty" > "$DEPS_DIR/base64/base64/.gitignore"
6165

6266
echo "All done!"
6367
echo ""

0 commit comments

Comments
 (0)