Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tools: don't gitignore base64 config.h #48174

Merged
merged 1 commit into from
May 30, 2023
Merged

tools: don't gitignore base64 config.h #48174

merged 1 commit into from
May 30, 2023

Conversation

bnoordhuis
Copy link
Member

The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds:

  1. Download and unpack tarball
  2. Check the sources into git with git init; git add .; git commit -a
  3. Clean the source tree with git clean -dfx
  4. Run ./configure && make
  5. Observe build failure because config.h is missing

Fixes: #47638

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 25, 2023
@bnoordhuis bnoordhuis mentioned this pull request May 25, 2023
Closed
@bnoordhuis bnoordhuis changed the title deps: don't gitignore base64 config.h tools: don't gitignore base64 config.h May 25, 2023
@bnoordhuis
tools: don't gitignore base64 config.h
cb448d5 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels May 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51978/

This was referenced May 28, 2023
Open
Open
@bnoordhuis bnoordhuis added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52000/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52002/

@github-actions github-actions bot mentioned this pull request May 30, 2023
Open
23 tasks
@bnoordhuis bnoordhuis added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit fe76e09 into nodejs:main May 30, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fe76e09

This was referenced May 31, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jun 4, 2023
@bnoordhuis @targos
tools: don't gitignore base64 config.h
5f08bfe 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: #47638
PR-URL: #48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Open
30 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@bnoordhuis @danielleadams
tools: don't gitignore base64 config.h
0b3f5ac 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: #47638
PR-URL: #48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@bnoordhuis @MoLow
tools: don't gitignore base64 config.h
361cf8c 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
PR-URL: nodejs#48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@bnoordhuis @Ceres6
tools: don't gitignore base64 config.h
e9e4929 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
PR-URL: nodejs#48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@bnoordhuis @Ceres6
tools: don't gitignore base64 config.h
f20633f 
The file is checked into git. Ignoring it causes a very non-obvious way
of breaking tarball builds:

1. Download and unpack tarball
2. Check the sources into git with `git init; git add .; git commit -a`
3. Clean the source tree with `git clean -dfx`
4. Run `./configure && make`
5. Observe build failure because config.h is missing

Fixes: nodejs#47638
PR-URL: nodejs#48174
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v18.x] broken build with ./configure --shared
7 participants
@bnoordhuis @nodejs-github-bot @lpinca @anonrig @targos @richardlau @marco-ippolito