Skip to content

Commit

Permalink
test: fix inspector tests
Browse files Browse the repository at this point in the history
The inspector tests should not be in the parallel directory as they
likely all (or certainly almost all) use static ports, so port
collisions will happen.

This moves them all to sequential. We can move them back on a
case-by-case basis. They were run sequentially when they were in the
inspector directory which they were only moved from very recently.

PR-URL: #16281
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
  • Loading branch information
Trott authored and targos committed Oct 18, 2017
1 parent 1fe5308 commit 1daf517
Show file tree
Hide file tree
Showing 24 changed files with 4 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ prefix parallel
[true] # This section applies to all platforms

[$system==win32]
test-inspector-bindings : PASS, FLAKY
test-inspector-debug-end : PASS, FLAKY
test-inspector-stop-profile-after-done: PASS, FLAKY

[$system==linux]

Expand All @@ -23,4 +20,3 @@ test-npm-install: PASS,FLAKY
[$system==freebsd]

[$system==aix]
test-inspector-stop-profile-after-done: PASS, FLAKY
4 changes: 4 additions & 0 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ prefix sequential
[true] # This section applies to all platforms

[$system==win32]
test-inspector-bindings : PASS, FLAKY
test-inspector-debug-end : PASS, FLAKY
test-inspector-stop-profile-after-done: PASS, FLAKY

[$system==linux]

Expand All @@ -17,3 +20,4 @@ prefix sequential
[$system==freebsd]

[$system==aix]
test-inspector-stop-profile-after-done: PASS, FLAKY
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 1daf517

Please # to comment.