Skip to content

Commit 452c3c2

Browse files
RafaelGSSaduh95
andauthored
Apply suggestions from code review
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 23fe596 commit 452c3c2

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/create-release-proposal.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,4 @@ jobs:
6767

6868
- name: Start git node release prepare
6969
run: |
70-
./tools/actions/create-release.sh "${RELEASE_DATE}"
70+
./tools/actions/create-release.sh "${RELEASE_DATE}" '${{ inputs.release-line }}'

tools/actions/create-release.sh

+4-3
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@
33
set -xe
44

55
RELEASE_DATE=$1
6+
RELEASE_LINE=$2
67

78
git node release --prepare --skipBranchDiff
89
# We use it to not specify the branch name as it changes based on
910
# the commit list (semver-minor/semver-patch)
1011
git config push.default current
11-
MATCHER="/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }"
12-
awk $MATCHER doc/changelogs/CHANGELOG_V23.md > pr-body.md
13-
gh pr create --body-file pr-body.md
12+
awk "/## ${RELEASE_DATE}/,/^<a id=/{ if (!/^<a id=/) print }" \
13+
"doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" |\
14+
gh pr create --body-file -
1415
# TODO: ammend with proposal PR

0 commit comments

Comments
 (0)