repl: fix crash when SharedArrayBuffer disabled

nodejs · Sep 2, 2021 · 7c3ed50 · 7c3ed50
1 parent 13b569c
commit 7c3ed50
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/benchmark/worker/atomics-wait.js b/benchmark/worker/atomics-wait.js
@@ -7,6 +7,10 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n }) {
+  if (typeof SharedArrayBuffer === 'undefined') {
+    throw new Error('SharedArrayBuffers must be enabled to run this benchmark');
+  }
+
   const i32arr = new Int32Array(new SharedArrayBuffer(4));
   bench.start();
   for (let i = 0; i < n; i++)

diff --git a/lib/internal/main/worker_thread.js b/lib/internal/main/worker_thread.js
@@ -9,7 +9,7 @@ const {
   ArrayPrototypeSplice,
   ObjectDefineProperty,
   PromisePrototypeCatch,
-  globalThis: { Atomics },
+  globalThis: { Atomics, SharedArrayBuffer },
 } = primordials;
 
 const {
@@ -142,6 +142,9 @@ port.on('message', (message) => {
     const originalCwd = process.cwd;
 
     process.cwd = function() {
+      // SharedArrayBuffers can be disabled with --no-harmony-sharedarraybuffer.
+      if (typeof SharedArrayBuffer === 'undefined') return originalCwd();
+
       const currentCounter = Atomics.load(cwdCounter, 0);
       if (currentCounter === lastCounter)
         return cachedCwd;

diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -91,7 +91,8 @@ let cwdCounter;
 
 const environmentData = new SafeMap();
 
-if (isMainThread) {
+// SharedArrayBuffers can be disabled with --no-harmony-sharedarraybuffer.
+if (isMainThread && typeof SharedArrayBuffer !== 'undefined') {
   cwdCounter = new Uint32Array(new SharedArrayBuffer(4));
   const originalChdir = process.chdir;
   process.chdir = function(path) {