Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move V8 inspector to stable #11770

Closed
targos opened this issue Mar 9, 2017 · 8 comments
Closed

Move V8 inspector to stable #11770

targos opened this issue Mar 9, 2017 · 8 comments
Labels
discuss Issues opened for discussions and feedbacks. inspector Issues and PRs related to the V8 inspector protocol

Comments

@targos
Copy link
Member

targos commented Mar 9, 2017 •
edited
Loading

The V8 inspector integration is currently considered an experimental feature in the docs.
Now that the debugger is deprecated, I think we should move the V8 inspector to stable and remove the --without-inspector configure flag before Node.js 8 is released.

/cc @nodejs/ctc @nodejs/v8-inspector
@targos targos added the inspector Issues and PRs related to the V8 inspector protocol label Mar 9, 2017
@targos targos added this to the 8.0.0 milestone Mar 9, 2017
@mscdex mscdex added the discuss Issues opened for discussions and feedbacks. label Mar 9, 2017
@cjihrig
Copy link
Contributor

cjihrig commented Mar 9, 2017

I agree. We should make it a stable feature. Many people are already relying on it as if it were stable.

@evanlucas
Copy link
Contributor

I agree that we should make it stable. I am curious as to the reasoning for removing the --without-inspector flag though

@targos
Copy link
Member Author

targos commented Mar 9, 2017

I thought the flag was here because of the experimental state of the feature. Is there another reason? Perhaps file size?

@evanlucas
Copy link
Contributor

I would think file size is good reason. FWIW, we also have a --without-npm flag too, so I personally think we should keep it.

@sam-github
Copy link
Contributor

agree it should be stable, and the flag to compile without it should be left in

@ofrobots
Copy link
Contributor

ofrobots commented Mar 9, 2017

I have added #11431 to the 8.0.0 milestone. If we are moving inspector to non-experimental, we should start the inspector, rather than the old debug protocol, on SIGUSR1.

@jkrems jkrems mentioned this issue Mar 15, 2017
Closed
14 tasks
@jkrems
Copy link
Contributor

jkrems commented Mar 15, 2017

Should we pull the runtime part (remove the experimental warning) into @joshgav's PR to update the hint text? #11207

@targos targos mentioned this issue Apr 3, 2017
Closed
@MylesBorins
Copy link
Contributor

I broke this out into it's own PR #12352

MylesBorins pushed a commit to MylesBorins/node that referenced this issue Apr 12, 2017
@joshgav @MylesBorins
src: remove experimental warning for inspect
4e6fdcd 
* Removes "experimental" warning.

Fixes: nodejs#11770
PR-URL: nodejs#12352
Reviewed-By: _tbd_
Reviewed-By: _tbd_
@refack refack mentioned this issue Apr 23, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
discuss Issues opened for discussions and feedbacks. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sam-github @mscdex @ofrobots @MylesBorins @jkrems @evanlucas @targos @cjihrig