Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

node-v8.0.0 make test failure #13344

Closed
bb-bc opened this issue May 31, 2017 · 4 comments
Closed

node-v8.0.0 make test failure #13344

bb-bc opened this issue May 31, 2017 · 4 comments
Labels
build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Comments

@bb-bc
Copy link

bb-bc commented May 31, 2017

  • Version: $ ./node -v
    v8.0.0

  • Platform: $ uname -a
    Linux vm-001 3.16.0-4-686-pae deps: update openssl to 1.0.1j #1 SMP Debian 3.16.43-2 (2017-04-30) i686 GNU/Linux

  • Subsystem: build system, make test

$ make test
make -C out BUILDTYPE=Release V=1
... 564 lines later...

[----------] Global test environment tear-down
[==========] 46 tests from 6 test cases ran. (113 ms total)
[ PASSED ] 46 tests.
/usr/bin/python tools/test.py --mode=release -J
doctool inspector known_issues message pseudo-tty parallel sequential
async-hooks addons addons-napi
=== release test ===
Path: addons-napi/test_instanceof/test
fs.js:638
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^

Error: ENOENT: no such file or directory, open '/usr/src/node-v8.0.0/deps/v8/test/mjsunit/instanceof.js'
at Object.fs.openSync (fs.js:638:18)
at Object.fs.readFileSync (fs.js:540:33)
at testFile (/usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js:37:23)
at Object. (/usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js:42:1)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Function.Module.runMain (module.js:605:10)
Command: out/Release/node --napi-modules /usr/src/node-v8.0.0/test/addons-napi/test_instanceof/test.js
[03:55|% 100|+ 1568|- 1]: Done
Makefile:196: recipe for target 'test' failed
make: *** [test] Error 1

@addaleax addaleax added build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels May 31, 2017
@addaleax
Copy link
Member

cc @nodejs/n-api

We should skip this test if the V8 test file is not present, I guess.

@gibfahn
Copy link
Member

gibfahn commented Jun 1, 2017

This is when you download the source from https://nodejs.org/dist/v6.10.3/node-v6.10.3.tar.gz (EDIT: v8.0.0) rather than doing a git clone I assume.

@bb-bc
Copy link
Author

bb-bc commented Jun 1, 2017

node.js download was from https://nodejs.org/dist/v8.0.0/node-v8.0.0.tar.gz

@ashtrankov
Copy link

ashtrankov commented Jul 1, 2017

It appears that the deps/v8/test directory is missing from the archive. And this is why its throwing errors for missing files. Cloning it from the repo could fix the issue.

cjihrig added a commit to cjihrig/node that referenced this issue Jul 13, 2017
The N-API test testInstanceOf.js relies on several V8 test files
which may not exist in downloadable archives. If the files are
missing, this commit causes a warning to be emitted rather than
failing the test.

Refs: nodejs#14113
Fixes: nodejs#13344
PR-URL: nodejs#14123
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Jul 18, 2017
The N-API test testInstanceOf.js relies on several V8 test files
which may not exist in downloadable archives. If the files are
missing, this commit causes a warning to be emitted rather than
failing the test.

Refs: #14113
Fixes: #13344
PR-URL: #14123
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this issue Jul 19, 2017
The N-API test testInstanceOf.js relies on several V8 test files
which may not exist in downloadable archives. If the files are
missing, this commit causes a warning to be emitted rather than
failing the test.

Refs: #14113
Fixes: #13344
PR-URL: #14123
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
The N-API test testInstanceOf.js relies on several V8 test files
which may not exist in downloadable archives. If the files are
missing, this commit causes a warning to be emitted rather than
failing the test.

Refs: nodejs#14113
Fixes: nodejs#13344
PR-URL: nodejs#14123
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
The N-API test testInstanceOf.js relies on several V8 test files
which may not exist in downloadable archives. If the files are
missing, this commit causes a warning to be emitted rather than
failing the test.

Refs: #14113
Fixes: #13344
Backport-PR-URL: #19447
PR-URL: #14123
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants