Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

c-ares: sync with upstream #1676

Closed
bnoordhuis opened this issue May 11, 2015 · 1 comment
Closed

c-ares: sync with upstream #1676

bnoordhuis opened this issue May 11, 2015 · 1 comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem.

Comments

@bnoordhuis
Copy link
Member

The bundled copy in deps/cares is https://github.com/piscisaureus/cares + two floating patches, last updated June 2013.

Sync with https://github.com/bagder/c-ares and maybe see if we can get those patches upstream.

/cc @indutny @piscisaureus
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 11, 2015
@bnoordhuis
deps: sync with upstream c-ares/c-ares@bba4dc5
2d07b07 
Fixes: nodejs#1676
@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem. labels May 11, 2015
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 11, 2015
@bnoordhuis
deps: sync with upstream c-ares/c-ares@bba4dc5
2f9b9dc 
Fixes: nodejs#1676
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 12, 2015
@bnoordhuis
deps: sync with upstream c-ares/c-ares@bba4dc5
7e1c0e7 
Fixes: nodejs#1676
PR-URL: nodejs#1678
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
Copy link
Member Author

Fixed by 7e1c0e7...08d0866 in #1678.

Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 19, 2015
@bnoordhuis @Fishrock123
deps: sync with upstream c-ares/c-ares@bba4dc5
8ebdb29 
Fixes: nodejs#1676
PR-URL: nodejs#1678
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@sambthompson sambthompson mentioned this issue Sep 1, 2015
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @bnoordhuis