Skip to content

investigate flaky parallel/test-http-client-timeout-agent #19804

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Trott opened this issue Apr 4, 2018 · 2 comments
Closed

investigate flaky parallel/test-http-client-timeout-agent #19804

Trott opened this issue Apr 4, 2018 · 2 comments

Comments

@Trott
Copy link
Member

Trott commented Apr 4, 2018

  • Version: 10.0.0-pre
  • Platform: aix
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-aix/13885/nodes=aix61-ppc64/console

not ok 717 parallel/test-http-client-timeout-agent
  ---
  duration_ms: 2.247
  severity: fail
  stack: |-
    res#0 data:0
    res#0 end
    res#2 data:2
    res#2 end
    res#4 data:4
    res#4 end
    res#6 data:6
    res#6 end
    res#8 data:8
    res#8 end
    res#10 data:10
    res#10 end
    res#12 data:12
    res#12 end
    res#14 data:14
    res#14 end
    res#16 data:16
    res#16 end
    res#18 data:18
    res#18 end
    res#20 data:20
    res#20 end
    res#22 data:22
    res#22 end
    res#24 data:24
    res#24 end
    res#26 data:26
    res#26 end
    res#28 data:28
    res#28 end
    req#1 timeout
    req#3 timeout
    req#5 timeout
    req#7 timeout
    req#9 timeout
    req#11 timeout
    req#13 timeout
    req#15 timeout
    req#17 timeout
    req#19 timeout
    req#21 timeout
    req#23 timeout
    req#25 timeout
    req#27 timeout
    req#29 timeout
    req#0 timeout
    req#28 close
    req#26 close
    req#24 close
    req#22 close
    req#20 close
    req#18 close
    req#16 close
    req#14 close
    req#12 close
    req#10 close
    req#8 close
    req#6 close
    req#4 close
    req#2 close
    req#0 close
    req#29 error
    req#29 close
    req#27 error
    req#27 close
    req#25 error
    req#25 close
    req#23 error
    req#23 close
    req#21 error
    req#21 close
    req#19 error
    req#19 close
    req#17 error
    req#17 close
    req#15 error
    req#15 close
    req#13 error
    req#13 close
    req#11 error
    req#11 close
    req#9 error
    req#9 close
    req#7 error
    req#7 close
    req#5 error
    req#5 close
    req#3 error
    req#3 close
    req#1 error
    req#1 close
    done=31 sent=30
    assert.js:80
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: 31 strictEqual 30
        at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-http-client-timeout-agent.js:93:10)
        at process.emit (events.js:187:15)
  ...
@Trott Trott mentioned this issue Apr 4, 2018
Closed
3 tasks
@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

And again, this time on FreeBSD:

https://ci.nodejs.org/job/node-test-commit-freebsd/16713/nodes=freebsd10-64/console

not ok 712 parallel/test-http-client-timeout-agent
  ---
  duration_ms: 2.88
  severity: fail
  stack: |-
    res#0 data:0
    res#0 end
    res#2 data:2
    res#2 end
    res#4 data:4
    res#4 end
    res#6 data:6
    res#6 end
    res#8 data:8
    res#8 end
    res#10 data:10
    res#10 end
    res#12 data:12
    res#12 end
    res#14 data:14
    res#14 end
    res#16 data:16
    res#16 end
    res#18 data:18
    res#18 end
    res#20 data:20
    res#20 end
    res#22 data:22
    res#22 end
    res#24 data:24
    res#24 end
    res#26 data:26
    res#26 end
    res#28 data:28
    res#28 end
    req#1 timeout
    req#3 timeout
    req#5 timeout
    req#7 timeout
    req#9 timeout
    req#11 timeout
    req#13 timeout
    req#15 timeout
    req#17 timeout
    req#19 timeout
    req#21 timeout
    req#23 timeout
    req#25 timeout
    req#27 timeout
    req#29 timeout
    req#0 timeout
    req#2 timeout
    req#28 close
    req#26 close
    req#24 close
    req#22 close
    req#20 close
    req#18 close
    req#16 close
    req#14 close
    req#12 close
    req#10 close
    req#8 close
    req#6 close
    req#4 close
    req#2 close
    req#0 close
    req#29 error
    req#29 close
    req#27 error
    req#27 close
    req#25 error
    req#25 close
    req#23 error
    req#23 close
    req#21 error
    req#21 close
    req#19 error
    req#19 close
    req#17 error
    req#17 close
    req#15 error
    req#15 close
    req#13 error
    req#13 close
    req#11 error
    req#11 close
    req#9 error
    req#9 close
    req#7 error
    req#7 close
    req#5 error
    req#5 close
    req#3 error
    req#3 close
    req#1 error
    req#1 close
    done=32 sent=30
    assert.js:80
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: 32 strictEqual 30
        at process.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-client-timeout-agent.js:93:10)
        at process.emit (events.js:187:15)
  ...

@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

Pretty easy to reproduce locally:

$ tools/test.py -j 16 --repeat 32 parallel/test-http-client-timeout-agent
=== release test-http-client-timeout-agent ===                    
Path: parallel/test-http-client-timeout-agent
res#0 data:0
res#0 end
res#2 data:2
res#2 end
res#4 data:4
res#4 end
res#6 data:6
res#6 end
res#8 data:8
res#8 end
res#10 data:10
res#10 end
res#12 data:12
res#12 end
res#14 data:14
res#14 end
res#16 data:16
res#16 end
res#18 data:18
res#18 end
res#20 data:20
res#20 end
req#1 timeout
req#3 timeout
req#5 timeout
req#7 timeout
req#9 timeout
req#11 timeout
req#13 timeout
req#15 timeout
req#17 timeout
req#19 timeout
req#21 timeout
req#22 timeout
req#23 timeout
req#24 timeout
req#25 timeout
req#26 timeout
req#27 timeout
req#28 timeout
req#29 timeout
req#0 timeout
req#2 timeout
req#4 timeout
req#6 timeout
req#8 timeout
req#10 timeout
req#12 timeout
req#14 timeout
req#16 timeout
req#18 timeout
req#20 timeout
req#20 close
req#18 close
req#16 close
req#14 close
req#12 close
req#10 close
req#8 close
req#6 close
req#4 close
req#2 close
req#0 close
req#29 error
req#29 close
req#28 error
req#28 close
req#27 error
req#27 close
req#26 error
req#26 close
req#25 error
req#25 close
req#24 error
req#24 close
req#23 error
req#23 close
req#22 error
req#22 close
req#21 error
req#21 close
req#19 error
req#19 close
req#17 error
req#17 close
req#15 error
req#15 close
req#13 error
req#13 close
req#11 error
req#11 close
req#9 error
req#9 close
req#7 error
req#7 close
req#5 error
req#5 close
req#3 error
req#3 close
req#1 error
req#1 close
done=41 sent=30
assert.js:80
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: 41 strictEqual 30
    at process.<anonymous> (/Users/trott/io.js/test/parallel/test-http-client-timeout-agent.js:93:10)
    at process.emit (events.js:187:15)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-client-timeout-agent.js
[00:03|% 100|+  31|-   1]: Done   
$

Trott added a commit to Trott/io.js that referenced this issue Apr 4, 2018
@Trott
test: fix flaky test-http-client-timeout-agent
c5ec829 
Move resource-sensitive test from parallel to sequential.

Fixes: nodejs#19804
@Trott Trott mentioned this issue Apr 4, 2018
Closed
2 tasks
@mhdawson mhdawson mentioned this issue Apr 5, 2018
Closed
3 tasks
@santigimeno santigimeno mentioned this issue Apr 6, 2018
Closed
4 tasks
@Trott Trott closed this as completed in 95dc590 Apr 7, 2018
santigimeno added a commit to santigimeno/node that referenced this issue Apr 7, 2018
@santigimeno
test: fix flaky http-client-timeout-agent
3f2078f 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

Fixes: nodejs#19804
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Apr 9, 2018
@santigimeno @BridgeAR
test: fix flaky http-client-timeout-agent
5b8c62c 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

PR-URL: nodejs#19856
Fixes: nodejs#19804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2018
@Trott @targos
test: move http-client-timeout-agent to sequential
ee63bfa 
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Apr 12, 2018
@santigimeno @targos
test: fix flaky http-client-timeout-agent
86e8a16 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

PR-URL: #19856
Fixes: #19804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue May 1, 2018
@Trott @BridgeAR
test: move http-client-timeout-agent to sequential
7b9f8fd 
Move resource-sensitive test from parallel to sequential.

Fixes: nodejs#19804

PR-URL: nodejs#19809
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue May 1, 2018
@santigimeno @BridgeAR
test: fix flaky http-client-timeout-agent
5029b43 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

PR-URL: nodejs#19856
Fixes: nodejs#19804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 1, 2018
@Trott @MylesBorins
test: move http-client-timeout-agent to sequential
9f3c414 
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 1, 2018
@santigimeno @MylesBorins
test: fix flaky http-client-timeout-agent
5436c7a 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

PR-URL: #19856
Fixes: #19804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this issue Aug 16, 2018
@Trott @rvagg
test: move http-client-timeout-agent to sequential
1e25f00 
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this issue Aug 16, 2018
@santigimeno @rvagg
test: fix flaky http-client-timeout-agent
d0588f1 
Close the connection immediately after receiving the `end` event to
avoid that the `timeout` event is fired before the connection closes
gracefully.
Move the test back to parallel.

PR-URL: #19856
Fixes: #19804
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Trott