Skip to content

http2 compat does not emit 'timeout' event on request object #20079

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ronag opened this issue Apr 16, 2018 · 1 comment
Closed

http2 compat does not emit 'timeout' event on request object #20079

ronag opened this issue Apr 16, 2018 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs. http2 Issues or PRs related to the http2 subsystem.

Comments

@ronag
Copy link
Member

ronag commented Apr 16, 2018 •
edited
Loading

http2 compat does not emit 'timeout' event on request object. It only invokes the setTimeout callback argument.
@apapirovski apapirovski added the http2 Issues or PRs related to the http2 subsystem. label Apr 17, 2018
@apapirovski
Copy link
Contributor

Yeah, this is definitely incorrect. We don't emit it on the response either. Both need to be fixed and should match the logic in http.

@apapirovski apapirovski added the confirmed-bug Issues with confirmed bugs. label Apr 17, 2018
DaAitch added a commit to wildoak/node that referenced this issue May 23, 2018
@DaAitch
http2: fix missing 'timeout' event emit in request and response
8eabb3f 
A timeout in a http2 stream should emit a 'timeout' event also on
request and response object. If there is no listener on stream,
request or response, stream should immediately be destroyed.

Fixes: nodejs#20079
@DaAitch DaAitch mentioned this issue May 23, 2018
Closed
4 tasks
@jasnell jasnell mentioned this issue Aug 10, 2018
Closed
3 tasks
jasnell added a commit to jasnell/node that referenced this issue Aug 10, 2018
@jasnell
http2: emit timeout on compat request and response
e8f319f 
Fixes: nodejs#20079
targos pushed a commit that referenced this issue Aug 19, 2018
@jasnell @targos
http2: emit timeout on compat request and response
384e881 
Fixes: #20079

PR-URL: #22252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this issue Sep 3, 2018
@jasnell @targos
http2: emit timeout on compat request and response
d3ceaa1 
Fixes: #20079

PR-URL: #22252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this issue Oct 3, 2018
@jasnell @kjin
http2: emit timeout on compat request and response
c4e0a27 
Fixes: nodejs#20079

PR-URL: nodejs#22252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this issue Oct 16, 2018
@jasnell @kjin
http2: emit timeout on compat request and response
3dc84ca 
v8.x Backport Note: The timeout has been increased to 10ms.

Fixes: nodejs#20079

PR-URL: nodejs#22252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Oct 17, 2018
@jasnell @BethGriggs
http2: emit timeout on compat request and response
348cde0 
v8.x Backport Note: The timeout has been increased to 10ms.

Fixes: #20079

Backport-PR-URL: #22850
PR-URL: #22252
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http2: fix missing 'timeout' event emit in request and response wildoak/node
2 participants
@apapirovski @ronag