Skip to content

investigate flaky known_issues/test-vm-timeout-escape-nexttick #24120

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Trott opened this issue Nov 6, 2018 · 10 comments
Closed

investigate flaky known_issues/test-vm-timeout-escape-nexttick #24120

Trott opened this issue Nov 6, 2018 · 10 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. vm Issues and PRs related to the vm subsystem.

Comments

@Trott
Copy link
Member

Trott commented Nov 6, 2018

https://ci.nodejs.org/job/node-test-commit-smartos/21423/nodes=smartos16-64/console

21:00:05 not ok 2313 known_issues/test-vm-timeout-escape-nexttick
21:00:05   ---
21:00:05   duration_ms: 0.525
21:00:05   severity: fail
21:00:05   stack: |-
21:00:05   ...

@jasnell
@Trott Trott added smartos Issues and PRs related to the SmartOS platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Nov 6, 2018
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

Fails reliably, it seems on Raspberry Pi devices.

https://ci.nodejs.org/job/node-test-binary-arm/3931/RUN_SUBSET=0,label=pi1-docker/console

01:56:21 not ok 313 known_issues/test-vm-timeout-escape-nexttick # TODO : Fix flaky test
01:56:21   ---
01:56:21   duration_ms: 2.609
01:56:21   severity: flaky
01:56:21   stack: |-
01:56:21   ...

https://ci.nodejs.org/job/node-test-binary-arm/3931/RUN_SUBSET=0,label=pi2-docker/console

00:12:31 not ok 313 known_issues/test-vm-timeout-escape-nexttick # TODO : Fix flaky test
00:12:31   ---
00:12:31   duration_ms: 1.235
00:12:31   severity: flaky
00:12:31   stack: |-
00:12:31   ...

https://ci.nodejs.org/job/node-test-binary-arm/3931/RUN_SUBSET=0,label=pi3-docker/console

00:09:09 not ok 313 known_issues/test-vm-timeout-escape-nexttick # TODO : Fix flaky test
00:09:09   ---
00:09:09   duration_ms: 0.927
00:09:09   severity: flaky
00:09:09   stack: |-
00:09:09   ...

@Trott Trott added vm Issues and PRs related to the vm subsystem. and removed smartos Issues and PRs related to the SmartOS platform. labels Nov 7, 2018
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

@nodejs/vm

@Trott Trott mentioned this issue Nov 7, 2018
Closed
3 tasks
Trott added a commit to Trott/io.js that referenced this issue Nov 7, 2018
@Trott
test: fix flaky VM timeout test on Raspberry Pi
f0d5829 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: nodejs#24120
@Trott Trott closed this as completed in d8e06b2 Nov 8, 2018
@refack
Copy link
Contributor

refack commented Nov 8, 2018

Still there testing https://github.com/nodejs/node/commits/8920d5d896b3f9b5df47b02e779ab49136cca085 which includes d8e06b2:

11:06:52 not ok 313 known_issues/test-vm-timeout-escape-nexttick
11:06:52   ---
11:06:52   duration_ms: 1.235
11:06:52   severity: fail
11:06:52   stack: |-
11:06:52   ...

https://ci.nodejs.org/job/node-test-commit-arm-fanned/4141/
https://ci.nodejs.org/job/node-test-binary-arm/3949/RUN_SUBSET=0,label=pi2-docker/console
https://ci.nodejs.org/computer/test-requireio_svincent-debian9-armv7l_pi2-1

@refack refack reopened this Nov 8, 2018
@Trott
Copy link
Member Author

Trott commented Nov 8, 2018

At least it's flaky now and not reliably failing. Will take a look. Solution might be to make the timeout bigger, which will make the test slower once we get it out of known_issues but shouldn't be a deal-breaker.

Trott added a commit to Trott/io.js that referenced this issue Nov 8, 2018
@Trott
test: fix flaky test-vm-timeout-escape-nexttick
8b29261 
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: nodejs#24120
@Trott Trott mentioned this issue Nov 8, 2018
Closed
2 tasks
Trott added a commit to Trott/io.js that referenced this issue Nov 9, 2018
@Trott
test: fix flaky test-vm-timeout-escape-nexttick
a4a2e9f 
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: nodejs#24120

PR-URL: nodejs#24251
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 9, 2018

Fixed in a4a2e9f

@Trott Trott closed this as completed Nov 9, 2018
BridgeAR pushed a commit that referenced this issue Nov 14, 2018
@Trott @BridgeAR
test: fix flaky VM timeout test on Raspberry Pi
415fcde 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: #24120

PR-URL: #24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this issue Nov 14, 2018
@Trott @BridgeAR
test: fix flaky test-vm-timeout-escape-nexttick
989c2aa 
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: #24120

PR-URL: #24251
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this issue Nov 15, 2018
@Trott @kiyomizumia
test: fix flaky VM timeout test on Raspberry Pi
872e1c3 
Increase the timeouts based on platform. This required adjusting
common.platformTimeout() to deal with bigint.

Fixes: nodejs#24120

PR-URL: nodejs#24238
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this issue Nov 15, 2018
@Trott @kiyomizumia
test: fix flaky test-vm-timeout-escape-nexttick
5309bb3 
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: nodejs#24120

PR-URL: nodejs#24251
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gireeshpunathil
Copy link
Member

looks like still failing - https://ci.nodejs.org/job/node-test-binary-arm/4403/RUN_SUBSET=0,label=pi1-docker/console

@Trott Trott reopened this Nov 28, 2018
@Trott
Copy link
Member Author

Trott commented Nov 28, 2018

Real solution is probably to fix the problem that this is a known_issues test for, since it will pass reliably then, even though it only mostly fails-as-expected right now.

@gireeshpunathil gireeshpunathil mentioned this issue Nov 29, 2018
Closed
4 tasks
Trott pushed a commit to Trott/io.js that referenced this issue Nov 29, 2018
@gireeshpunathil @Trott
test: mark test-vm-timeout-escape-nexttick flaky
9e33e86 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this issue Nov 29, 2018
@gireeshpunathil @targos
test: mark test-vm-timeout-escape-nexttick flaky
1035e36 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this issue Jan 12, 2019
@Trott @codebytere
test: fix flaky test-vm-timeout-escape-nexttick
a30f5a0 
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: #24120

PR-URL: #24251
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@gireeshpunathil @refack
test: mark test-vm-timeout-escape-nexttick flaky
a4a6b68 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Feb 12, 2019
@gireeshpunathil @BethGriggs
test: mark test-vm-timeout-escape-nexttick flaky
e89f5e5 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Feb 17, 2019

https://ci.nodejs.org/job/node-test-binary-arm/6218/RUN_SUBSET=3,label=pi2-docker/console

test-requireio_joeyvandijk-debian9-armv7l_pi2-2

00:09:38 not ok 376 known_issues/test-vm-timeout-escape-nexttick # TODO : Fix flaky test
00:09:38   ---
00:09:38   duration_ms: 1.543
00:09:38   severity: flaky
00:09:38   stack: |-
00:09:38   ...

rvagg pushed a commit that referenced this issue Feb 28, 2019
@gireeshpunathil @rvagg
test: mark test-vm-timeout-escape-nexttick flaky
28aca77 
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Mar 2, 2019

https://ci.nodejs.org/job/node-test-commit-linux-containered/10964/nodes=ubuntu1604_sharedlibs_debug_x64/console

test-digitalocean-ubuntu1604_sharedlibs_container-x64-7

00:15:31 not ok 2270 known_issues/test-vm-timeout-escape-nexttick
00:15:31   ---
00:15:31   duration_ms: 1.62
00:15:31   severity: fail
00:15:31   stack: |-
00:15:31   ...

@sam-github sam-github added the arm Issues and PRs related to the ARM platform. label Jun 7, 2019
Trott added a commit to Trott/io.js that referenced this issue Jun 27, 2019
@Trott
test: fix flaky test-vm-timeout-escape-nexttick
6810113 
Fixes: nodejs#24120
@Trott
Copy link
Member Author

Trott commented Jun 27, 2019

https://ci.nodejs.org/job/node-test-commit-linux-containered/13604/nodes=ubuntu1604_sharedlibs_zlib_x64/console

test-digitalocean-ubuntu1604_sharedlibs_container-x64-1

00:19:50 not ok 2579 known_issues/test-vm-timeout-escape-nexttick
00:19:50   ---
00:19:50   duration_ms: 0.247
00:19:50   severity: fail
00:19:50   stack: |-
00:19:50   ...

@Trott Trott mentioned this issue Jun 27, 2019
Closed
2 tasks
@danbev danbev closed this as completed in e008ca8 Jul 2, 2019
targos pushed a commit that referenced this issue Jul 2, 2019
@Trott @targos
test: fix flaky test-vm-timeout-escape-nexttick
7665bad 
PR-URL: #28461
Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 2, 2019
@Trott @targos
test: fix flaky test-vm-timeout-escape-nexttick
8a64b70 
PR-URL: #28461
Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
4 participants
@sam-github @refack @Trott @gireeshpunathil