Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Investigate flaky parallel/test-fs-stat-bigint #24565

Closed
Trott opened this issue Nov 22, 2018 · 1 comment
Closed

Investigate flaky parallel/test-fs-stat-bigint #24565

Trott opened this issue Nov 22, 2018 · 1 comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.

Comments

@Trott
Copy link
Member

Trott commented Nov 22, 2018 •
edited by refack
Loading 

00:09:12 not ok 95 parallel/test-fs-stat-bigint
00:09:12   ---
00:09:12   duration_ms: 3.698
00:09:12   severity: fail
00:09:12   exitcode: 1
00:09:12   stack: |-
00:09:12     assert.js:86
00:09:12       throw new AssertionError(obj);
00:09:12       ^
00:09:12     
00:09:12     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
00:09:12     + actual - expected
00:09:12     
00:09:12     + 1542874151832n
00:09:12     - 1542874151833n
00:09:12                   ^
00:09:12         at verifyStats (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-stat-bigint.js:65:14)
00:09:12         at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-fs-stat-bigint.js:88:3)
00:09:12         at Module._compile (internal/modules/cjs/loader.js:722:30)
00:09:12         at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
00:09:12         at Module.load (internal/modules/cjs/loader.js:620:32)
00:09:12         at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
00:09:12         at Function.Module._load (internal/modules/cjs/loader.js:552:3)
00:09:12         at Function.Module.runMain (internal/modules/cjs/loader.js:775:12)
00:09:12         at startup (internal/bootstrap/node.js:300:19)
00:09:12         at bootstrapNodeJSCore (internal/bootstrap/node.js:826:3)
00:09:12   ...

Haven't seen this one fail before. Off-by-one/rounding-truncation error?

I'll open a PR to add more info to the assertion and then we can close this unless/until it fails again.

[refack: edited info and added link to test file]
@Trott Trott mentioned this issue Nov 22, 2018
Closed
2 tasks
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 22, 2018
Trott added a commit to Trott/io.js that referenced this issue Nov 22, 2018
@Trott
test: add information to assertion
c186d46 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

Refs: nodejs#24565
danbev pushed a commit that referenced this issue Nov 23, 2018
@Trott @danbev
test: add information to assertion
b303d8b 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott Trott closed this as completed Nov 23, 2018
@Trott Trott mentioned this issue Nov 24, 2018
Closed
targos pushed a commit that referenced this issue Nov 24, 2018
@Trott @targos
test: add information to assertion
67adfdf 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@refack
Copy link
Contributor

refack commented Nov 25, 2018

Possible fix/clarify - #23821

@refack refack added fs Issues and PRs related to the fs subsystem / file system. arm Issues and PRs related to the ARM platform. labels Nov 25, 2018
rvagg pushed a commit that referenced this issue Nov 28, 2018
@Trott @rvagg
test: add information to assertion
765a81e 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere pushed a commit that referenced this issue Jan 13, 2019
@Trott @codebytere
test: add information to assertion
3ff3238 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@Trott @refack
test: add information to assertion
5a6c08a 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: nodejs#24566
Refs: nodejs#24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere pushed a commit that referenced this issue Jan 29, 2019
@Trott @codebytere
test: add information to assertion
a98470e 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere pushed a commit that referenced this issue Jan 29, 2019
@Trott @codebytere
test: add information to assertion
546af69 
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refack @Trott