-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
TextDecoder should not output BOM #25315
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
confirmed-bug
Issues with confirmed bugs.
encoding
Issues and PRs related to the TextEncoder and TextDecoder APIs.
Comments
cc @nodejs/i18n |
Sorry, pinged the wrong team @nodejs/intl |
2 tasks
PR merged, should be close. |
PR was merged, but the bug still exists. Both failing tests are skipped: node/test/wpt/status/encoding.json Lines 24 to 29 in 7c9ee6d
|
3 tasks
addaleax
added a commit
to addaleax/node
that referenced
this issue
Nov 1, 2019
Do not accept the BOM if it comes from a different encoding, and only discard the BOM after it has actually been read (including when it is spread over multiple chunks in streaming mode). Fixes: nodejs#25315
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
confirmed-bug
Issues with confirmed bugs.
encoding
Issues and PRs related to the TextEncoder and TextDecoder APIs.
Found when porting encoding WPT into core.
Spec: https://encoding.spec.whatwg.org/#concept-td-serialize
Failing tests:
The text was updated successfully, but these errors were encountered: