crypto::Hash update method error output is missing Buffer

[amitzur]

• Version: 10.10.0
• Platform: Linux amit-ThinkPad-X1-Carbon-6th 4.15.0-43-generic #46-Ubuntu SMP Thu Dec 6 14:45:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: crypto

The Hash class in the crypto module has an update method which may receive {string | Buffer | TypedArray | DataView} in the data argument.
(https://github.com/nodejs/node/blob/master/doc/api/crypto.md#hashupdatedata-inputencoding)

The error message output if an invalid argument type is passed is missing Buffer.
(https://github.com/nodejs/node/blob/master/lib/internal/crypto/hash.js#L65)

I believe this is a good first bug, and would like to fix it myself. AFAICT, a test should be added here:
https://github.com/nodejs/node/blob/master/test/parallel/test-crypto-hash.js

If this issue is verified, I just need a pointer to how to run the tests in test/parallel.

[bnoordhuis]

Thanks for the excellent bug report. Yes, that looks like a genuine oversight to me, pull request most welcome.

[bnoordhuis]

If this issue is verified, I just need a pointer to how to run the tests in test/parallel.

make test-parallel or python tools/test.py -J parallel

(edit: or just make test to run everything)

[sam-github]

Running make test is a good idea to do just before making a pull request. Besides just running the tests, it will check for style errors in the js and markdown files and other common problems, saving you from making the PR, and then having CI immediately fail it.

[amitzur]

Great point. I'm working on it. Thanks!

[amitzur]

Any idea why I'm getting this error during make -j4 test ?
btw, running python tools/test.py -J parallel/test-fs-stat-bigint.js works fine. I hope it's the same test.

AssertionError [ERR_ASSERTION]: atimeMs is not a safe integer, difference should < 1.
Number version 1547551430183.6504, BigInt version 1547551430179n
    at verifyStats (/home/amit/projects/node/test/parallel/test-fs-stat-bigint.js:72:7)
    at fs.lstat (/home/amit/projects/node/test/parallel/test-fs-stat-bigint.js:120:7)
    at FSReqCallback.oncomplete (fs.js:160:5)

Node version: both 10.10.0 and 8.12.0

[bnoordhuis]

@amitzur That's probably #24593. Summary: flaky test (on some systems.)

[amitzur]

thanks @bnoordhuis . I assumed this so I allowed myself to file a PR already. And indeed the checks passed.