Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

investigate flaky sequential/test-performance #25903

Closed
Trott opened this issue Feb 3, 2019 · 3 comments
Closed

investigate flaky sequential/test-performance #25903

Trott opened this issue Feb 3, 2019 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Comments

@Trott
Copy link
Member

Trott commented Feb 3, 2019

https://ci.nodejs.org/job/node-test-binary-arm/5919/RUN_SUBSET=3,label=pi1-docker/console

test-requireio_bengl-debian9-armv6l_pi1p-2

00:41:48 not ok 400 sequential/test-performance
00:41:48   ---
00:41:48   duration_ms: 3.197
00:41:48   severity: fail
00:41:48   exitcode: 1
00:41:48   stack: |-
00:41:48     { name: 'node',
00:41:48       entryType: 'node',
00:41:48       startTime: 0,
00:41:48       duration: { around: 2624.797483444214 },
00:41:48       nodeStart: { around: 0 },
00:41:48       v8Start: { around: 0 },
00:41:48       bootstrapComplete: { around: 2430.326003074646, delay: 2500 },
00:41:48       environment: { around: 0 },
00:41:48       loopStart: -1,
00:41:48       loopExit: -1 }
00:41:48     assert.js:351
00:41:48         throw err;
00:41:48         ^
00:41:48     
00:41:48     AssertionError [ERR_ASSERTION]: duration: 266.82491397857666 >= 250
00:41:48         at checkNodeTiming (/home/iojs/build/workspace/node-test-binary-arm/test/sequential/test-performance.js:67:7)
00:41:48         at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/sequential/test-performance.js:79:1)
00:41:48         at Module._compile (internal/modules/cjs/loader.js:735:30)
00:41:48         at Object.Module._extensions..js (internal/modules/cjs/loader.js:746:10)
00:41:48         at Module.load (internal/modules/cjs/loader.js:627:32)
00:41:48         at tryModuleLoad (internal/modules/cjs/loader.js:570:12)
00:41:48         at Function.Module._load (internal/modules/cjs/loader.js:562:3)
00:41:48         at Function.Module.runMain (internal/modules/cjs/loader.js:798:12)
00:41:48         at internal/main/run_main_module.js:27:11
00:41:48   ...

@apapirovski @TimothyGu @jasnell

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Feb 3, 2019
@Trott
Copy link
Member Author

Trott commented Feb 3, 2019

Would the use of common.platformTimeout() be appropriate here? Or would that just cover up a legitimate bug?

const delay = common.platformTimeout(250);

@mscdex
Copy link
Contributor

mscdex commented Apr 15, 2019

This is still happening, this time on test-digitalocean-ubuntu1604_sharedlibs_container-x64-7:

11:54:30 not ok 2407 sequential/test-performance
11:54:30   ---
11:54:30   duration_ms: 0.867
11:54:30   severity: fail
11:54:30   exitcode: 1
11:54:30   stack: |-
11:54:30     {
11:54:30       name: 'node',
11:54:30       entryType: 'node',
11:54:30       startTime: 0,
11:54:30       duration: { around: 709.9882780313492 },
11:54:30       nodeStart: { around: 0 },
11:54:30       v8Start: { around: 0 },
11:54:30       bootstrapComplete: { around: 692.6773769855499, delay: 2500 },
11:54:30       environment: { around: 0 },
11:54:30       loopStart: -1,
11:54:30       loopExit: -1
11:54:30     }
11:54:30     assert.js:345
11:54:30         throw err;
11:54:30         ^
11:54:30     
11:54:30     AssertionError [ERR_ASSERTION]: environment: 295.2118600010872 >= 250
11:54:30         at checkNodeTiming (/home/iojs/build/workspace/node-test-commit-linux-containered/test/sequential/test-performance.js:67:7)
11:54:30         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/sequential/test-performance.js:79:1)
11:54:30         at Module._compile (internal/modules/cjs/loader.js:766:30)
11:54:30         at Object.Module._extensions..js (internal/modules/cjs/loader.js:777:10)
11:54:30         at Module.load (internal/modules/cjs/loader.js:635:32)
11:54:30         at Function.Module._load (internal/modules/cjs/loader.js:562:12)
11:54:30         at Function.Module.runMain (internal/modules/cjs/loader.js:830:10)
11:54:30         at internal/main/run_main_module.js:17:11

@targos
Copy link
Member

targos commented Nov 20, 2021

Closing as there was no recent activity

@targos targos closed this as completed Nov 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Development

No branches or pull requests

3 participants