test: rename test-performance to test-perf-hooks #27969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename test-performance to test-perf-hooks to better match its function Refs: nodejs#27884 (comment)
|
LGTM but let's ping @nodejs/performance @jasnell just in case.... |
|
Sure. |
addaleax
approved these changes
May 30, 2019
cjihrig
approved these changes
May 30, 2019
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
May 30, 2019
ZYSzys
added
author ready
trivikr
approved these changes
May 31, 2019
Reminder to rename #25903 |
|
Passed! Landing this. |
|
Landed in 389804e 🎉 |
ryzokuken
added a commit
that referenced
this pull request
Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename test-performance to test-perf-hooks to better match its function
Refs: #27884 (comment)
/cc @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes