Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

11.9.0 console history is missing "the just-run command" #26013

Closed
Pomax opened this issue Feb 8, 2019 · 3 comments · Fixed by #26037
Closed

11.9.0 console history is missing "the just-run command" #26013

Pomax opened this issue Feb 8, 2019 · 3 comments · Fixed by #26037

Comments

@Pomax
Copy link

Pomax commented Feb 8, 2019

I just installed Node 11.9.0 for Windows, fired it up with node and then ran:

> [1,[2,[3]]].flat()
[ 1, 2, [ 3 ] ]
>▐

I then tapped the "up" cursor, except nothing showed up. I then continued:

> [1,[2,[3]]].flat()
[ 1, 2, [ 3 ] ]
> [4,[5,[6]]].flat()
[ 4, 5, [ 6 ] ]
>▐

I then tapped the "up" cursor key again, and got this:

> [1,[2,[3]]].flat()
[ 1, 2, [ 3 ] ]
> [4,[5,[6]]].flat()
[ 4, 5, [ 6 ] ]
> [1,[2,[3]]].flat()▐

So for some reason, the nodejs console history is skipping whatever code has just been run, which feels like a classic off-by-one bug.

@richardlau
Copy link
Member

I think this is #25875.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 8, 2019

I can confirm that the previous step is not skipped, just the UP key fires twice and jumps to the next to last step quickly.

@Pomax
Copy link
Author

Pomax commented Feb 9, 2019

cool, then this issue need not remain open. Thanks for the check.

@Pomax Pomax closed this as completed Feb 9, 2019
cjihrig pushed a commit to libuv/libuv that referenced this issue Feb 10, 2019
Refs: #2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: #2168
PR-URL: #2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this issue Feb 13, 2019
Notable changes:
- A bug that could result in 100% CPU utilization in Node
  has been fixed (libuv/libuv#2162)
- Node's report module will now include the entire Windows
  product name (libuv/libuv#2170)

PR-URL: nodejs#26037
Fixes: nodejs#26013
Fixes: nodejs#25875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit that referenced this issue Feb 13, 2019
Notable changes:
- A bug that could result in 100% CPU utilization in Node
  has been fixed (libuv/libuv#2162)
- Node's report module will now include the entire Windows
  product name (libuv/libuv#2170)

PR-URL: #26037
Fixes: #26013
Fixes: #25875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
njlr pushed a commit to buckaroo-pm/libuv that referenced this issue Apr 5, 2019
Refs: libuv#2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: libuv#2168
PR-URL: libuv#2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this issue May 16, 2019
Notable changes:
- A bug that could result in 100% CPU utilization in Node
  has been fixed (libuv/libuv#2162)
- Node's report module will now include the entire Windows
  product name (libuv/libuv#2170)

PR-URL: nodejs#26037
Fixes: nodejs#26013
Fixes: nodejs#25875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
Notable changes:
- A bug that could result in 100% CPU utilization in Node
  has been fixed (libuv/libuv#2162)
- Node's report module will now include the entire Windows
  product name (libuv/libuv#2170)

Backport-PR-URL: #27728
PR-URL: #26037
Fixes: #26013
Fixes: #25875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
musm pushed a commit to musm/libuv that referenced this issue Jul 9, 2020
Refs: libuv#2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: libuv#2168
PR-URL: libuv#2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 7ed1ece)
musm pushed a commit to musm/libuv that referenced this issue Jul 9, 2020
Refs: libuv#2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: libuv#2168
PR-URL: libuv#2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 7ed1ece)
musm pushed a commit to musm/libuv that referenced this issue Jul 9, 2020
Refs: libuv#2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: libuv#2168
PR-URL: libuv#2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 7ed1ece)
musm pushed a commit to musm/libuv that referenced this issue Jul 14, 2020
Refs: libuv#2114
Refs: nodejs/node#25875
Refs: nodejs/node#26013
Fixes: libuv#2168
PR-URL: libuv#2160
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
(cherry picked from commit 7ed1ece)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants