Skip to content

http2.connect's listener Parameter is Not Explained in The Documentation #28217

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
anliting opened this issue Jun 13, 2019 · 0 comments
Closed

http2.connect's listener Parameter is Not Explained in The Documentation #28217

anliting opened this issue Jun 13, 2019 · 0 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@anliting
Copy link

  • Version: 12.4.0
  • Platform: not important
  • Subsystem: http2

http2.connect's listener parameter is not explained in the documentation: https://nodejs.org/api/http2.html#http2_http2_connect_authority_options_listener
@lpinca lpinca added the doc Issues and PRs related to the documentations. label Jun 24, 2019
@lpinca lpinca mentioned this issue Jul 1, 2019
Closed
3 tasks
lpinca added a commit to lpinca/node that referenced this issue Jul 4, 2019
@lpinca
doc: add description for the listener argument
796355e 
Clarify that `listener` is registered as a one-time listener of the
`'connect'` event.

Fixes: nodejs#28217
@lpinca lpinca closed this as completed Jul 6, 2019
lpinca added a commit that referenced this issue Jul 6, 2019
@lpinca
doc: add description for the listener argument
8850ef2 
Clarify that `listener` is registered as a one-time listener of the
`'connect'` event.

PR-URL: #28500
Fixes: #28217
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this issue Jul 20, 2019
@lpinca @targos
doc: add description for the listener argument
24a77ae 
Clarify that `listener` is registered as a one-time listener of the
`'connect'` event.

PR-URL: #28500
Fixes: #28217
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add description for the listener argument lpinca/node
2 participants
@lpinca @anliting